Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fix recursive self calls #37321

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix recursive self calls #37321

merged 2 commits into from
Nov 4, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Nov 4, 2022

This recursive self-call will get flagged in the upcoming linter release.

See: https://dart-review.googlesource.com/c/sdk/+/264961

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@pq
Copy link
Contributor Author

pq commented Nov 4, 2022

Since this is in tools I'd expect it to be test-exempt.

Alternatively, I could revert this change and add an ignore if that's preferred.

@pq pq requested a review from goderbauer November 4, 2022 17:44
@pq
Copy link
Contributor Author

pq commented Nov 4, 2022

@goderbauer: WDYT?

@pq pq requested review from cbracken and removed request for goderbauer November 4, 2022 18:52
@pq
Copy link
Contributor Author

pq commented Nov 4, 2022

Looks like @goderbauer is out... @cbracken: would you mind taking a look?

@Hixie
Copy link
Contributor

Hixie commented Nov 4, 2022

test-exemption: code refactor with no semantic change

@pq pq added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2022
@auto-submit auto-submit bot merged commit 24c3a9f into flutter:main Nov 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 5, 2022
…114728)

* 24c3a9f51 fix recursive self calls (flutter/engine#37321)

* 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328)

* ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 7, 2022
Downstream fixes:

* flutter/flutter#113794
* flutter/plugins#6669
* flutter/engine#37321
* dart-archive/linter#3775
* dart-archive/linter#3776

* cl/482614222
* cl/482654980
* cl/482744309
* cl/485129394
* cl/485139323
* ...

Upstream:

* #50263

Change-Id: I259cb0c28464b1e513d9a1931b7c680a2a04a0a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264961
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
* fix recursive self calls

* update tool signature
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#114728)

* 24c3a9f51 fix recursive self calls (flutter/engine#37321)

* 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328)

* ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#114728)

* 24c3a9f51 fix recursive self calls (flutter/engine#37321)

* 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328)

* ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants