-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Since this is in Alternatively, I could revert this change and add an |
@goderbauer: WDYT? |
Looks like @goderbauer is out... @cbracken: would you mind taking a look? |
test-exemption: code refactor with no semantic change |
…114728) * 24c3a9f51 fix recursive self calls (flutter/engine#37321) * 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328) * ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
Downstream fixes: * flutter/flutter#113794 * flutter/plugins#6669 * flutter/engine#37321 * dart-archive/linter#3775 * dart-archive/linter#3776 * cl/482614222 * cl/482654980 * cl/482744309 * cl/485129394 * cl/485139323 * ... Upstream: * #50263 Change-Id: I259cb0c28464b1e513d9a1931b7c680a2a04a0a4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264961 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
* fix recursive self calls * update tool signature
…lutter#114728) * 24c3a9f51 fix recursive self calls (flutter/engine#37321) * 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328) * ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
…lutter#114728) * 24c3a9f51 fix recursive self calls (flutter/engine#37321) * 2a1be6d4d Roll Skia from dc49f35e1ac6 to 7a98accb20d5 (6 revisions) (flutter/engine#37328) * ba390f2a7 [web] Unify JS configuration. Make it available from initEngine. (flutter/engine#37187)
This recursive self-call will get flagged in the upcoming linter release.
See: https://dart-review.googlesource.com/c/sdk/+/264961
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.