Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

unnecessary_overrides fix false positive for commented super calls #3776

Merged
merged 2 commits into from
Oct 20, 2022
Merged

unnecessary_overrides fix false positive for commented super calls #3776

merged 2 commits into from
Oct 20, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Oct 20, 2022

@github-actions github-actions bot added the linter-set-core Affects a rule in the core Dart rule set label Oct 20, 2022
@pq pq merged commit 3659d9a into main Oct 20, 2022
@pq pq deleted the fp_unnec_overrides branch October 20, 2022 20:06
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.788% when pulling c89ecc7 on fp_unnec_overrides into 5161322 on main.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 7, 2022
@pq
linter 1.29.0
ca52c30 
Downstream fixes:

* flutter/flutter#113794
* flutter/plugins#6669
* flutter/engine#37321
* dart-archive/linter#3775
* dart-archive/linter#3776

* cl/482614222
* cl/482654980
* cl/482744309
* cl/485129394
* cl/485139323
* ...

Upstream:

* #50263

Change-Id: I259cb0c28464b1e513d9a1931b7c680a2a04a0a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264961
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
unnecessary_overrides fix false positive for commented super calls (d…
ff23306 
…art-archive/linter#3776)

* allow commented super calls

* ++
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
linter-set-core Affects a rule in the core Dart rule set
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pq @coveralls @bwilkerson