Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Oct 22, 2022

Remove duplicated _ from Android's test methods' name. It's a minor cleanup PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented Oct 22, 2022

Hi @zanderso , could you help to assign folks to help review this simple PR? Thanks.

@stuartmorgan-g
Copy link
Contributor

@GaryQian Do you know if there's a historical reason for this naming? It does seem unusual.

@GaryQian
Copy link
Contributor

I've noticed this but I never found out why. There are many instances so it seems unlikely it was an accident.

I know we have (had?) Double underscores in shard names, I wonder if this was imitating that format.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I wouldn't expect this to actually impact anything (and all the tests still pass so it doesn't seem to be a workaround for something), let's just standardize on something more common. LGTM.

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agree, let's go ahead with this.

@GaryQian GaryQian added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2022
@auto-submit auto-submit bot merged commit 7cd0778 into flutter:main Oct 24, 2022
@utzcoz utzcoz deleted the clean-up-Android-test-method-name branch October 24, 2022 16:28
@utzcoz
Copy link
Contributor Author

utzcoz commented Oct 24, 2022

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants