Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 7cd0778

Browse files
utzcozutzcoz
authored
Remove duplicated _ from Android's test methods' name (#36944)
1 parent 168c711 commit 7cd0778

File tree

3 files changed

+32
-32
lines changed

3 files changed

+32
-32
lines changed

‎shell/platform/android/test/io/flutter/embedding/android/FlutterFragmentActivityTest.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ public void tearDown() {
6565
}
6666

6767
@Test
68-
public void createFlutterFragment__defaultRenderModeSurface() {
68+
public void createFlutterFragment_defaultRenderModeSurface() {
6969
final FlutterFragmentActivity activity = new FakeFlutterFragmentActivity();
7070
assertEquals(activity.createFlutterFragment().getRenderMode(), RenderMode.surface);
7171
}
7272

7373
@Test
74-
public void createFlutterFragment__defaultRenderModeTexture() {
74+
public void createFlutterFragment_defaultRenderModeTexture() {
7575
final FlutterFragmentActivity activity =
7676
new FakeFlutterFragmentActivity() {
7777
@Override
@@ -83,7 +83,7 @@ protected BackgroundMode getBackgroundMode() {
8383
}
8484

8585
@Test
86-
public void createFlutterFragment__customRenderMode() {
86+
public void createFlutterFragment_customRenderMode() {
8787
final FlutterFragmentActivity activity =
8888
new FakeFlutterFragmentActivity() {
8989
@Override
@@ -95,7 +95,7 @@ protected RenderMode getRenderMode() {
9595
}
9696

9797
@Test
98-
public void createFlutterFragment__customDartEntrypointLibraryUri() {
98+
public void createFlutterFragment_customDartEntrypointLibraryUri() {
9999
final FlutterFragmentActivity activity =
100100
new FakeFlutterFragmentActivity() {
101101
@Override

‎shell/platform/android/test/io/flutter/embedding/engine/FlutterJNITest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public void computePlatformResolvedLocaleCallsLocalizationPluginProperly() {
150150
assertEquals(result[2], "");
151151
}
152152

153-
public void onDisplayPlatformView__callsPlatformViewsController() {
153+
public void onDisplayPlatformView_callsPlatformViewsController() {
154154
PlatformViewsController platformViewsController = mock(PlatformViewsController.class);
155155

156156
FlutterJNI flutterJNI = new FlutterJNI();
@@ -181,7 +181,7 @@ public void onDisplayPlatformView__callsPlatformViewsController() {
181181
}
182182

183183
@Test
184-
public void onDisplayOverlaySurface__callsPlatformViewsController() {
184+
public void onDisplayOverlaySurface_callsPlatformViewsController() {
185185
PlatformViewsController platformViewsController = mock(PlatformViewsController.class);
186186

187187
FlutterJNI flutterJNI = new FlutterJNI();
@@ -197,7 +197,7 @@ public void onDisplayOverlaySurface__callsPlatformViewsController() {
197197
}
198198

199199
@Test
200-
public void onBeginFrame__callsPlatformViewsController() {
200+
public void onBeginFrame_callsPlatformViewsController() {
201201
PlatformViewsController platformViewsController = mock(PlatformViewsController.class);
202202

203203
// --- Test Setup ---
@@ -212,7 +212,7 @@ public void onBeginFrame__callsPlatformViewsController() {
212212
}
213213

214214
@Test
215-
public void onEndFrame__callsPlatformViewsController() {
215+
public void onEndFrame_callsPlatformViewsController() {
216216
PlatformViewsController platformViewsController = mock(PlatformViewsController.class);
217217

218218
// --- Test Setup ---
@@ -227,7 +227,7 @@ public void onEndFrame__callsPlatformViewsController() {
227227
}
228228

229229
@Test
230-
public void createOverlaySurface__callsPlatformViewsController() {
230+
public void createOverlaySurface_callsPlatformViewsController() {
231231
PlatformViewsController platformViewsController = mock(PlatformViewsController.class);
232232

233233
FlutterJNI flutterJNI = new FlutterJNI();
@@ -241,14 +241,14 @@ public void createOverlaySurface__callsPlatformViewsController() {
241241
}
242242

243243
@Test(expected = IllegalArgumentException.class)
244-
public void invokePlatformMessageResponseCallback__wantsDirectBuffer() {
244+
public void invokePlatformMessageResponseCallback_wantsDirectBuffer() {
245245
FlutterJNI flutterJNI = new FlutterJNI();
246246
ByteBuffer buffer = ByteBuffer.allocate(4);
247247
flutterJNI.invokePlatformMessageResponseCallback(0, buffer, buffer.position());
248248
}
249249

250250
@Test
251-
public void setRefreshRateFPS__callsUpdateRefreshRate() {
251+
public void setRefreshRateFPS_callsUpdateRefreshRate() {
252252
FlutterJNI flutterJNI = spy(new FlutterJNI());
253253
// --- Execute Test ---
254254
flutterJNI.setRefreshRateFPS(120.0f);

‎shell/platform/android/test/io/flutter/plugin/platform/PlatformViewsControllerTest.java‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ public void itUsesActionEventTypeFromMotionEventForHybridPlatformViews() {
268268

269269
@Test
270270
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
271-
public void getPlatformViewById__hybridComposition() {
271+
public void getPlatformViewById_hybridComposition() {
272272
PlatformViewsController platformViewsController = new PlatformViewsController();
273273

274274
int platformViewId = 0;
@@ -296,7 +296,7 @@ public void getPlatformViewById__hybridComposition() {
296296

297297
@Test
298298
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
299-
public void createPlatformViewMessage__initializesAndroidView() {
299+
public void createPlatformViewMessage_initializesAndroidView() {
300300
PlatformViewsController platformViewsController = new PlatformViewsController();
301301

302302
int platformViewId = 0;
@@ -318,7 +318,7 @@ public void createPlatformViewMessage__initializesAndroidView() {
318318

319319
@Test
320320
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
321-
public void createPlatformViewMessage__wrapsContextForVirtualDisplay() {
321+
public void createPlatformViewMessage_wrapsContextForVirtualDisplay() {
322322
PlatformViewsController platformViewsController = new PlatformViewsController();
323323

324324
int platformViewId = 0;
@@ -343,7 +343,7 @@ public void createPlatformViewMessage__wrapsContextForVirtualDisplay() {
343343

344344
@Test
345345
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
346-
public void createPlatformViewMessage__doesNotWrapContextForHybrid() {
346+
public void createPlatformViewMessage_doesNotWrapContextForHybrid() {
347347
PlatformViewsController platformViewsController = new PlatformViewsController();
348348

349349
int platformViewId = 0;
@@ -367,7 +367,7 @@ public void createPlatformViewMessage__doesNotWrapContextForHybrid() {
367367

368368
@Test
369369
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
370-
public void createPlatformViewMessage__setsAndroidViewLayoutDirection() {
370+
public void createPlatformViewMessage_setsAndroidViewLayoutDirection() {
371371
PlatformViewsController platformViewsController = new PlatformViewsController();
372372
platformViewsController.setSoftwareRendering(true);
373373

@@ -393,7 +393,7 @@ public void createPlatformViewMessage__setsAndroidViewLayoutDirection() {
393393

394394
@Test
395395
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
396-
public void createPlatformViewMessage__setsAndroidViewSize() {
396+
public void createPlatformViewMessage_setsAndroidViewSize() {
397397
PlatformViewsController platformViewsController = new PlatformViewsController();
398398
platformViewsController.setSoftwareRendering(true);
399399

@@ -426,7 +426,7 @@ public void createPlatformViewMessage__setsAndroidViewSize() {
426426

427427
@Test
428428
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
429-
public void createPlatformViewMessage__disablesAccessibility() {
429+
public void createPlatformViewMessage_disablesAccessibility() {
430430
PlatformViewsController platformViewsController = new PlatformViewsController();
431431
platformViewsController.setSoftwareRendering(true);
432432

@@ -453,7 +453,7 @@ public void createPlatformViewMessage__disablesAccessibility() {
453453

454454
@Test
455455
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
456-
public void createPlatformViewMessage__throwsIfViewIsNull() {
456+
public void createPlatformViewMessage_throwsIfViewIsNull() {
457457
PlatformViewsController platformViewsController = new PlatformViewsController();
458458

459459
int platformViewId = 0;
@@ -482,7 +482,7 @@ public void createPlatformViewMessage__throwsIfViewIsNull() {
482482

483483
@Test
484484
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
485-
public void createHybridPlatformViewMessage__throwsIfViewIsNull() {
485+
public void createHybridPlatformViewMessage_throwsIfViewIsNull() {
486486
PlatformViewsController platformViewsController = new PlatformViewsController();
487487

488488
int platformViewId = 0;
@@ -574,7 +574,7 @@ public void onPreEngineRestart_clearsPlatformViewContext() {
574574

575575
@Test
576576
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
577-
public void createPlatformViewMessage__throwsIfViewHasParent() {
577+
public void createPlatformViewMessage_throwsIfViewHasParent() {
578578
PlatformViewsController platformViewsController = new PlatformViewsController();
579579

580580
int platformViewId = 0;
@@ -605,7 +605,7 @@ public void createPlatformViewMessage__throwsIfViewHasParent() {
605605

606606
@Test
607607
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
608-
public void createHybridPlatformViewMessage__throwsIfViewHasParent() {
608+
public void createHybridPlatformViewMessage_throwsIfViewHasParent() {
609609
PlatformViewsController platformViewsController = new PlatformViewsController();
610610

611611
int platformViewId = 0;
@@ -635,7 +635,7 @@ public void createHybridPlatformViewMessage__throwsIfViewHasParent() {
635635

636636
@Test
637637
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
638-
public void setPlatformViewDirection__throwIfPlatformViewNotFound() {
638+
public void setPlatformViewDirection_throwIfPlatformViewNotFound() {
639639
PlatformViewsController platformViewsController = new PlatformViewsController();
640640

641641
int platformViewId = 0;
@@ -706,7 +706,7 @@ public void resizeAndroidView() {
706706

707707
@Test
708708
@Config(shadows = {ShadowFlutterJNI.class, ShadowPlatformTaskQueue.class})
709-
public void disposeAndroidView__hybridComposition() {
709+
public void disposeAndroidView_hybridComposition() {
710710
PlatformViewsController platformViewsController = new PlatformViewsController();
711711

712712
int platformViewId = 0;
@@ -803,7 +803,7 @@ public void disposeNullAndroidView() {
803803
ShadowFlutterJNI.class,
804804
ShadowPlatformTaskQueue.class
805805
})
806-
public void onEndFrame__destroysOverlaySurfaceAfterFrameOnFlutterSurfaceView() {
806+
public void onEndFrame_destroysOverlaySurfaceAfterFrameOnFlutterSurfaceView() {
807807
final PlatformViewsController platformViewsController = new PlatformViewsController();
808808

809809
final int platformViewId = 0;
@@ -862,7 +862,7 @@ public void onEndFrame__destroysOverlaySurfaceAfterFrameOnFlutterSurfaceView() {
862862

863863
@Test
864864
@Config(shadows = {ShadowFlutterSurfaceView.class, ShadowFlutterJNI.class})
865-
public void onEndFrame__removesPlatformView() {
865+
public void onEndFrame_removesPlatformView() {
866866
final PlatformViewsController platformViewsController = new PlatformViewsController();
867867

868868
final int platformViewId = 0;
@@ -903,7 +903,7 @@ public void onEndFrame__removesPlatformView() {
903903
ShadowFlutterJNI.class,
904904
ShadowPlatformTaskQueue.class
905905
})
906-
public void onEndFrame__removesPlatformViewParent() {
906+
public void onEndFrame_removesPlatformViewParent() {
907907
final PlatformViewsController platformViewsController = new PlatformViewsController();
908908

909909
final int platformViewId = 0;
@@ -946,7 +946,7 @@ public void onEndFrame__removesPlatformViewParent() {
946946
ShadowFlutterJNI.class,
947947
ShadowPlatformTaskQueue.class
948948
})
949-
public void detach__destroysOverlaySurfaces() {
949+
public void detach_destroysOverlaySurfaces() {
950950
final PlatformViewsController platformViewsController = new PlatformViewsController();
951951

952952
final int platformViewId = 0;
@@ -997,7 +997,7 @@ public void detach__destroysOverlaySurfaces() {
997997

998998
@Test
999999
@Config(shadows = {ShadowFlutterSurfaceView.class, ShadowFlutterJNI.class})
1000-
public void detachFromView__removesAndDestroysOverlayViews() {
1000+
public void detachFromView_removesAndDestroysOverlayViews() {
10011001
final PlatformViewsController platformViewsController = new PlatformViewsController();
10021002

10031003
final int platformViewId = 0;
@@ -1035,7 +1035,7 @@ public void detachFromView__removesAndDestroysOverlayViews() {
10351035

10361036
@Test
10371037
@Config(shadows = {ShadowFlutterSurfaceView.class, ShadowFlutterJNI.class})
1038-
public void destroyOverlaySurfaces__doesNotThrowIfFlutterViewIsDetached() {
1038+
public void destroyOverlaySurfaces_doesNotThrowIfFlutterViewIsDetached() {
10391039
final PlatformViewsController platformViewsController = new PlatformViewsController();
10401040

10411041
final int platformViewId = 0;
@@ -1073,7 +1073,7 @@ public void destroyOverlaySurfaces__doesNotThrowIfFlutterViewIsDetached() {
10731073

10741074
@Test
10751075
@Config(shadows = {ShadowFlutterSurfaceView.class, ShadowFlutterJNI.class})
1076-
public void destroyOverlaySurfaces__doesNotRemoveOverlayView() {
1076+
public void destroyOverlaySurfaces_doesNotRemoveOverlayView() {
10771077
final PlatformViewsController platformViewsController = new PlatformViewsController();
10781078

10791079
final int platformViewId = 0;
@@ -1107,7 +1107,7 @@ public void destroyOverlaySurfaces__doesNotRemoveOverlayView() {
11071107
}
11081108

11091109
@Test
1110-
public void checkInputConnectionProxy__falseIfViewIsNull() {
1110+
public void checkInputConnectionProxy_falseIfViewIsNull() {
11111111
final PlatformViewsController platformViewsController = new PlatformViewsController();
11121112
boolean shouldProxying = platformViewsController.checkInputConnectionProxy(null);
11131113
assertFalse(shouldProxying);

0 commit comments

Comments
 (0)