Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Remove EngineParagraph and ParagraphGeometricStyle #30766

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jan 10, 2022

The classes EngineParagraph and ParagraphGeometricStyle aren't needed anymore. This PR removes them and all references to them.

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Jan 10, 2022
@mdebbar mdebbar requested a review from yjbanov January 10, 2022 17:52
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 10, 2022
@fluttergithubbot fluttergithubbot merged commit 358605c into flutter:main Jan 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 11, 2022
* 58305d1 Roll Skia from dd575bc0f1f5 to 0056f3f006de (2 revisions) (flutter/engine#30765)

* 92a4f99 Allow additional expose_dirs in flutter_runner (flutter/engine#30749)

* 358605c [web] Remove EngineParagraph and ParagraphGeometricStyle (flutter/engine#30766)

* 8b9f625 Remove glitch when displaying platform views (flutter/engine#30724)

* bd65330 Add missing dependencies to the background image app (flutter/engine#30769)

* 65dfc9e [android] Remove the FlutterView casting, add a @nonnull and fix code style (flutter/engine#30734)

* 00e2a47 Roll Skia from 0056f3f006de to 3e1354a592bc (3 revisions) (flutter/engine#30771)

* 279e3af Implemented library uri support for FlutterFragments and FlutterActivities (flutter/engine#30726)

* 36ad9f1 Roll Skia from 3e1354a592bc to 55b4dc3f7a1c (1 revision) (flutter/engine#30773)
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
@mdebbar mdebbar deleted the engine_paragraph branch January 17, 2023 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants