This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow additional expose_dirs in flutter_runner #30749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On #29875 David suggested putting new component arguments into an We could take the list as comma-separated values, e.g. "--expose_dirs=dir1,dir2,dir3". |
Sure I can do that. |
Users can add an expose_dirs entry to the program field in a component's cml file to optionally expose extra directories from their out/ directory. BUG: fxbug.dev/89690
chaselatta
force-pushed
the
expose_dirs
branch
from
0a2bfb1 to
c4d8d32
Compare
arbreng
approved these changes
Jan 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 11, 2022
* 58305d1 Roll Skia from dd575bc0f1f5 to 0056f3f006de (2 revisions) (flutter/engine#30765) * 92a4f99 Allow additional expose_dirs in flutter_runner (flutter/engine#30749) * 358605c [web] Remove EngineParagraph and ParagraphGeometricStyle (flutter/engine#30766) * 8b9f625 Remove glitch when displaying platform views (flutter/engine#30724) * bd65330 Add missing dependencies to the background image app (flutter/engine#30769) * 65dfc9e [android] Remove the FlutterView casting, add a @nonnull and fix code style (flutter/engine#30734) * 00e2a47 Roll Skia from 0056f3f006de to 3e1354a592bc (3 revisions) (flutter/engine#30771) * 279e3af Implemented library uri support for FlutterFragments and FlutterActivities (flutter/engine#30726) * 36ad9f1 Roll Skia from 3e1354a592bc to 55b4dc3f7a1c (1 revision) (flutter/engine#30773)
JsouLiang
pushed a commit
to JsouLiang/engine
that referenced
this pull request
Jan 14, 2022
Users can add an expose_dirs entry to the program field in a component's cml file to optionally expose extra directories from their out/ directory. BUG: fxbug.dev/89690
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can add an expose_dirs entry to the program field in a
component's cml file to optionally expose extra directories
from their out/ directory.
BUG: fxbug.dev/89690