Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ci.yaml] Add xcode property to ci.yaml #27415

Merged
merged 2 commits into from
Jul 15, 2021
Merged

[ci.yaml] Add xcode property to ci.yaml #27415

merged 2 commits into from
Jul 15, 2021

Conversation

CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Jul 14, 2021 •
edited
Loading

flutter/flutter#84998
flutter/flutter#85491

In the future, it would allow changes like https://flutter-review.googlesource.com/c/infra/+/15101 to be tracked in the engine repo.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Jul 14, 2021
christopherfujino
christopherfujino approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 14, 2021
@jmagman jmagman removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 14, 2021
@jmagman
Copy link
Member

jmagman commented Jul 14, 2021

Is this actually used yet? Or is it still respecting engine_config.star? I need to coordinate this Xcode version change with the engine team.

@jmagman
Copy link
Member

jmagman commented Jul 14, 2021

Is this actually used yet? Or is it still respecting engine_config.star? I need to coordinate this Xcode version change with the engine team.

@christopherfujino says this property is currently ignored.

jmagman
jmagman approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 14, 2021
@christopherfujino christopherfujino mentioned this pull request Jul 14, 2021
Closed
jmagman
jmagman suggested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to roll back 13a5155e, can you make this 12a7209?

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This pull request has changes requested by @jmagman. Please resolve those before re-applying the label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 15, 2021
jmagman
jmagman approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the thrash!

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 15, 2021
@fluttergithubbot fluttergithubbot merged commit 6e62915 into master Jul 15, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2021
@engine-flutter-autoroll
6e62915 [ci.yaml] Add xcode property to ci.yaml (flutter/engine#27415)
0d97143
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2021
@engine-flutter-autoroll
6e62915 [ci.yaml] Add xcode property to ci.yaml (flutter/engine#27415)
591f049
flar pushed a commit to flutter/flutter that referenced this pull request Jul 15, 2021
@engine-flutter-autoroll
Roll Engine from 093c4ed to 8bb5760 (37 revisions) (#86508)
6036b14 
* a7b5522 refactor and simplify CI dart analysis (flutter/engine#27370)

* 137009b Switch test_suites to yaml. (flutter/engine#27368)

* a22a3ca [web] fix a few analysis lints (flutter/engine#27375)

* a02c017 make it work on <API 24 (flutter/engine#27398)

* 0220256 Make FlutterFragment usable without requiring it to be attached to an Android Activity. (Attempt 2) (flutter/engine#27397)

* 51e07a5 [fuchsia] Use FFI to get System clockMonotonic (flutter/engine#27353)

* 4015d8b Roll Skia from 224e3e257d06 to 773a0b8c7e74 (44 revisions) (flutter/engine#27399)

* 7db1a96 [ci.yaml] Add Linux Android Scenarios postsubmit (flutter/engine#27400)

* a02f6bc remove the use of package:isolate (flutter/engine#27401)

* 3237f4f Roll Skia from 773a0b8c7e74 to 36c1804e8f5c (1 revision) (flutter/engine#27402)

* 75af7c8 Roll Dart SDK from ab009483f343 to 746879714c96 (5 revisions) (flutter/engine#27403)

* be21e40 [ci.yaml] Add linux benchmarks, add enabled branches (flutter/engine#27405)

* c8d7a97 Roll Fuchsia Mac SDK from wUg-tGGCL... to uhahzGJ6H... (flutter/engine#27408)

* 3649200 Roll Skia from 36c1804e8f5c to 947a2eb3c043 (7 revisions) (flutter/engine#27410)

* f04d941 [web] enable always_specify_types lint (flutter/engine#27406)

* bdaaa4f [fuchsia] fix race in DefaultSessionConnection (flutter/engine#27377)

* 84247f2 Update the Fuchsia runner to use fpromise instead of fit::promise (flutter/engine#27416)

* 39119d2 Roll Skia from 947a2eb3c043 to 9081276b2907 (6 revisions) (flutter/engine#27426)

* 9002bc7 Roll Skia from 9081276b2907 to 0547b914f691 (2 revisions) (flutter/engine#27430)

* 58e0688 Roll Fuchsia Linux SDK from hykYtaK7D... to s2vrjrfuS... (flutter/engine#27431)

* 1dca887 Roll Dart SDK from 746879714c96 to d53eb1066384 (2 revisions) (flutter/engine#27432)

* c9008f3 Use python to run firebase testlab, do not expect recipe to know location of APK (flutter/engine#27434)

* 8f7c529 Roll Skia from 0547b914f691 to 7d336c9557bd (3 revisions) (flutter/engine#27436)

* 534404e Roll Fuchsia Mac SDK from uhahzGJ6H... to TWPguQ-ow... (flutter/engine#27438)

* 9f13308 Roll Dart SDK from d53eb1066384 to fcbaa0a90b4b (1 revision) (flutter/engine#27439)

* e5e7b94 Roll Skia from 7d336c9557bd to 7dc26fadc90b (2 revisions) (flutter/engine#27440)

* bf3d265 Roll Skia from 7dc26fadc90b to dd561d021470 (1 revision) (flutter/engine#27442)

* 6e62915 [ci.yaml] Add xcode property to ci.yaml (flutter/engine#27415)

* 33c17a1 Roll Skia from dd561d021470 to 0e99fbe5da5c (1 revision) (flutter/engine#27443)

* 0bc2479 Adjust web_sdk rule deps (flutter/engine#27435)

* 7a8969a [web] enable prefer_final_locals lint (flutter/engine#27420)

* 590902b Roll Dart SDK from fcbaa0a90b4b to 207232b5abe0 (1 revision) (flutter/engine#27446)

* 283a42f fuchsia: Log vsync stats in inspect (flutter/engine#27433)

* 4af14b9 Deeplink URI fragment on Android and iOS (flutter/engine#26185)

* 47899db Remove unused generate_dart_ui target (flutter/engine#27445)

* fb265c2 Roll Skia from 0e99fbe5da5c to a2d22b2e085e (3 revisions) (flutter/engine#27447)

* 8bb5760 [ci.yaml] Mark Linux Android Scenarios as flaky (flutter/engine#27422)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@moffatman
[ci.yaml] Add xcode property to ci.yaml (flutter#27415)
89c8695
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
[ci.yaml] Add xcode property to ci.yaml (flutter#27415)
4e07b04
@CaseyHillers CaseyHillers deleted the CaseyHillers-patch-2 branch November 18, 2021 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyHillers @jmagman @fluttergithubbot @christopherfujino