refactor and simplify CI dart analysis #27370

devoncarew · 2021-07-13T19:30:42Z

Refactor and simplify CI dart analysis:

remove a no longer used exclude in the top-level analysis options file
add a new analysis options file to lib/ui/; this lets us use regular dart analysis in that directory (excluding some code that references a dart library that doesn't yet exist)
refactor ci/analyze.sh to use dart analyze instead of the older dartanalyzer tool
include lib/web_ui/ in what we analyze from ci/analyze.sh

Note one change from above - we've switched from analyzing the generated artifact "$SRC_DIR/out/host_debug_unopt/gen/sky/bindings/dart_ui/ui.dart" to the source directory "$FLUTTER_DIR/lib/ui". I believe this covers the same code - that the build step doesn't transmute it in some way that we should test - but would like someone to confirm.

devoncarew · 2021-07-13T22:01:47Z

Somewhat related to #27367.

dnfield · 2021-07-13T22:13:43Z

analysis_options.yaml

-  exclude: [
-    # this test pretends to be part of dart:ui and results in lots of false
-    # positives.
-    testing/dart/window_hooks_integration_test.dart,


Woohoo! this file doesn't exist anymore.

dnfield · 2021-07-13T22:16:38Z

ci/analyze.sh

+echo ""
+
+# Analyze dart:ui.
+dart analyze "$FLUTTER_DIR/lib/ui"


The only thing this might be missing is that the previous way validates that _embedder.yaml generated is correct, whereas this does not. So we will miss if someone messes up _embedder.yaml

I believe this was previously just validating out/host_debug_unopt/gen/dart-pkg/sky_engine/lib/ui/hooks.dart (and perhaps the part files in out/host_debug_unopt/gen/dart-pkg/sky_engine/lib/ui/ as a side effect)?

Through it would also be good to validate _embedder.yaml for sure.

dart -> "$DART" here and below.

This previously validated the whole dart:ui generated library AFAICT. It does not just look at hooks.dart.

dnfield · 2021-07-13T22:18:02Z

ci/analyze.sh

+dart analyze "$FLUTTER_DIR/lib/ui"
+
+# Analyze Flutter web's dart:ui.
+(cd "$FLUTTER_DIR/lib/web_ui"; dart pub get)


Can we somehow avoid running pub get from here? I know we run it below for web_sdk. We're trying to move to doing pub get --offline from gclient sync to avoid random network connection failures messing up various build steps.

(I'm taking a quick look to see if I can migrate the pubspec there to work offline)

I can remove this from the PR? It wasn't validated here before.

I can also switch to using --offline here - I'm not sure how set up the pub cache is at this point. We could also not run pub get, and rely on some other build step running it. I'm not familiar enough w/ the build of this repo to say.

I would like to work towards being able to analyze the dart code in this repo on its own - without it having to be a full gclient checkout and having run a large ninja build. That would enable us to do more pre-submit testing of the dart code in this repo from the dart-lanbg/sdk CI system.

The pubspec has some non-trivial deps in it. It'd be good to migrate but will likely take some time.

However, we also run analysis on that target in //lib/web_ui/dev/web_engine_analysis.sh, so it seems like we probably shouldn't be doing it here - at least until it can avoid doing a pub get.

You don't need to do a full ninja build to analyze dart:ui - you can just build the sky_engine target, which is a pretty small target that mainly just copies files around.

Doing it without a gclient sync is a tougher ask - we really need to do that to make sure we're getting the right dart:* libraries and package dependencies we have from the SDK.

OK, I removed the web_ui validation from this PR.

@dnfield - wrt the sky_engine target - is that just running ninja -v -C out/host_debug_unopt flutter/sky/packages/sky_engine? Or something else?

That's correct

zanderso

Thanks for doing this!

zanderso · 2021-07-13T22:24:24Z

ci/analyze.sh

+echo ""
+
+# Analyze dart:ui.
+dart analyze "$FLUTTER_DIR/lib/ui"


dart -> "$DART" here and below.

devoncarew

Thanks for the reviews! I removed the web_ui validation, and updated references in the script from dart to "$DART".

devoncarew · 2021-07-13T23:06:19Z

ci/analyze.sh

+dart analyze "$FLUTTER_DIR/lib/ui"
+
+# Analyze Flutter web's dart:ui.
+(cd "$FLUTTER_DIR/lib/web_ui"; dart pub get)


OK, I removed the web_ui validation from this PR.

dnfield · 2021-07-13T23:27:30Z

ci/analyze.sh

+"$DART" --version
+echo ""
+
+"$DART" analyze "$FLUTTER_DIR/lib/ui"


Do we know for sure if we're losing coverage of _embedder.yaml with this or not?

This code previously definitely didn't know about directories higher than out/host_debug_unopt/gen/dart-pkg/sky_engine/lib/ui/ - where _embedder.yaml and the other packages it references are. So I don't think we're regressing testing here. I.e., this also doesn't get us testing of _embedder.yaml, but we didn't have that before.

Ahh ok makes sense

dnfield

Lgtm

* a7b5522 refactor and simplify CI dart analysis (flutter/engine#27370) * 137009b Switch test_suites to yaml. (flutter/engine#27368) * a22a3ca [web] fix a few analysis lints (flutter/engine#27375) * a02c017 make it work on <API 24 (flutter/engine#27398) * 0220256 Make FlutterFragment usable without requiring it to be attached to an Android Activity. (Attempt 2) (flutter/engine#27397) * 51e07a5 [fuchsia] Use FFI to get System clockMonotonic (flutter/engine#27353) * 4015d8b Roll Skia from 224e3e257d06 to 773a0b8c7e74 (44 revisions) (flutter/engine#27399) * 7db1a96 [ci.yaml] Add Linux Android Scenarios postsubmit (flutter/engine#27400) * a02f6bc remove the use of package:isolate (flutter/engine#27401) * 3237f4f Roll Skia from 773a0b8c7e74 to 36c1804e8f5c (1 revision) (flutter/engine#27402) * 75af7c8 Roll Dart SDK from ab009483f343 to 746879714c96 (5 revisions) (flutter/engine#27403) * be21e40 [ci.yaml] Add linux benchmarks, add enabled branches (flutter/engine#27405) * c8d7a97 Roll Fuchsia Mac SDK from wUg-tGGCL... to uhahzGJ6H... (flutter/engine#27408) * 3649200 Roll Skia from 36c1804e8f5c to 947a2eb3c043 (7 revisions) (flutter/engine#27410) * f04d941 [web] enable always_specify_types lint (flutter/engine#27406) * bdaaa4f [fuchsia] fix race in DefaultSessionConnection (flutter/engine#27377) * 84247f2 Update the Fuchsia runner to use fpromise instead of fit::promise (flutter/engine#27416) * 39119d2 Roll Skia from 947a2eb3c043 to 9081276b2907 (6 revisions) (flutter/engine#27426) * 9002bc7 Roll Skia from 9081276b2907 to 0547b914f691 (2 revisions) (flutter/engine#27430) * 58e0688 Roll Fuchsia Linux SDK from hykYtaK7D... to s2vrjrfuS... (flutter/engine#27431) * 1dca887 Roll Dart SDK from 746879714c96 to d53eb1066384 (2 revisions) (flutter/engine#27432) * c9008f3 Use python to run firebase testlab, do not expect recipe to know location of APK (flutter/engine#27434) * 8f7c529 Roll Skia from 0547b914f691 to 7d336c9557bd (3 revisions) (flutter/engine#27436) * 534404e Roll Fuchsia Mac SDK from uhahzGJ6H... to TWPguQ-ow... (flutter/engine#27438) * 9f13308 Roll Dart SDK from d53eb1066384 to fcbaa0a90b4b (1 revision) (flutter/engine#27439) * e5e7b94 Roll Skia from 7d336c9557bd to 7dc26fadc90b (2 revisions) (flutter/engine#27440) * bf3d265 Roll Skia from 7dc26fadc90b to dd561d021470 (1 revision) (flutter/engine#27442) * 6e62915 [ci.yaml] Add xcode property to ci.yaml (flutter/engine#27415) * 33c17a1 Roll Skia from dd561d021470 to 0e99fbe5da5c (1 revision) (flutter/engine#27443) * 0bc2479 Adjust web_sdk rule deps (flutter/engine#27435) * 7a8969a [web] enable prefer_final_locals lint (flutter/engine#27420) * 590902b Roll Dart SDK from fcbaa0a90b4b to 207232b5abe0 (1 revision) (flutter/engine#27446) * 283a42f fuchsia: Log vsync stats in inspect (flutter/engine#27433) * 4af14b9 Deeplink URI fragment on Android and iOS (flutter/engine#26185) * 47899db Remove unused generate_dart_ui target (flutter/engine#27445) * fb265c2 Roll Skia from 0e99fbe5da5c to a2d22b2e085e (3 revisions) (flutter/engine#27447) * 8bb5760 [ci.yaml] Mark Linux Android Scenarios as flaky (flutter/engine#27422)

refactor and simplify CI dart analysis

f3dfde6

google-cla bot added the cla: yes label Jul 13, 2021

devoncarew added 4 commits July 13, 2021 13:12

run pub get for web dart:ui

0ecd3aa

fix the pub get command

6e13c77

remove a deprecated pubspec field

84b82e6

merge to master

f911b71

devoncarew marked this pull request as ready for review July 13, 2021 22:01

devoncarew requested review from dnfield and zanderso July 13, 2021 22:01

dnfield reviewed Jul 13, 2021

View reviewed changes

zanderso reviewed Jul 13, 2021

View reviewed changes

review comments

7829fa7

devoncarew commented Jul 13, 2021

View reviewed changes

dnfield reviewed Jul 13, 2021

View reviewed changes

dnfield approved these changes Jul 14, 2021

View reviewed changes

zanderso approved these changes Jul 14, 2021

View reviewed changes

zanderso added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 14, 2021

fluttergithubbot merged commit a7b5522 into flutter:master Jul 14, 2021

engine-flutter-autoroll mentioned this pull request Jul 14, 2021

Roll Engine from 093c4ed1a3d7 to a7b5522de504 (1 revision) flutter/flutter#86408

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2021

a7b5522 refactor and simplify CI dart analysis (flutter/engine#27370)

65a0c2c

engine-flutter-autoroll mentioned this pull request Jul 15, 2021

Roll Engine from 093c4ed1a3d7 to 6491d17331ab (39 revisions) flutter/flutter#86505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2021

a7b5522 refactor and simplify CI dart analysis (flutter/engine#27370)

c21506a

engine-flutter-autoroll mentioned this pull request Jul 15, 2021

Roll Engine from 093c4ed1a3d7 to 8bb5760c0920 (37 revisions) flutter/flutter#86508

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 15, 2021

a7b5522 refactor and simplify CI dart analysis (flutter/engine#27370)

674e156

moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021

refactor and simplify CI dart analysis (flutter#27370)

6a15a5a

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

refactor and simplify CI dart analysis (flutter#27370)

6beeffb

refactor and simplify CI dart analysis #27370

refactor and simplify CI dart analysis #27370

Uh oh!

Conversation

devoncarew commented Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devoncarew commented Jul 13, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devoncarew left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devoncarew commented Jul 13, 2021 •

edited

Loading