Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

--sound-null-safety instead of enable-experiment where possible #26999

Merged
merged 5 commits into from
Jun 29, 2021
Merged

--sound-null-safety instead of enable-experiment where possible #26999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4be812
No more experiments
dnfield Jun 28, 2021
07b6f72
missing file
dnfield Jun 28, 2021
35855fc
one more missing one
dnfield Jun 28, 2021
b75e2c4
remove duplicate args
dnfield Jun 29, 2021
434772c
revert removals
dnfield Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/snapshot/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ compiled_action("generate_snapshot_bin") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--snapshot_kind=core",
"--enable_mirrors=false",
"--vm_snapshot_data=" + rebase_path(vm_snapshot_data),
Expand Down
3 changes: 1 addition & 2 deletions testing/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ def SnapshotTest(build_dir, test_packages, dart_file, kernel_file_output, verbos
dart,
'--disable-dart-dev',
frontend_server,
'--enable-experiment=non-nullable',
'--no-sound-null-safety',
'--sound-null-safety',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VM tests are all migrated, this will fail on CI if there is any mistake.

'--sdk-root',
flutter_patched_sdk,
'--incremental',
Expand Down
2 changes: 1 addition & 1 deletion testing/testing.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ template("dart_snapshot_kernel") {
rebase_path("$root_out_dir/flutter_patched_sdk"),
"--target",
"flutter",
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--output-dill",
rebase_path(invoker.dart_kernel, root_out_dir),
"--depfile",
Expand Down
12 changes: 4 additions & 8 deletions web_sdk/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_outline") {
script = "//third_party/dart/utils/bazel/kernel_worker.dart"

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--summary-only",
"--target",
"ddc",
Expand Down Expand Up @@ -162,7 +162,7 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--compile-sdk",
"dart:core",

Expand Down Expand Up @@ -215,7 +215,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--compile-sdk",
"dart:core",

Expand Down Expand Up @@ -270,7 +270,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--compile-sdk",
"dart:core",

Expand Down Expand Up @@ -325,7 +325,6 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_sound") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--compile-sdk",
"dart:core",
Expand Down Expand Up @@ -380,7 +379,6 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk_sound") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--compile-sdk",
"dart:core",
Expand Down Expand Up @@ -436,7 +434,6 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk_sound") {
]

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--compile-sdk",
"dart:core",
Expand Down Expand Up @@ -487,7 +484,6 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_outline_sound") {
script = "//third_party/dart/utils/bazel/kernel_worker.dart"

args = [
"--enable-experiment=non-nullable",
"--sound-null-safety",
"--summary-only",
"--target",
Expand Down