--sound-null-safety instead of enable-experiment where possible #26999

dnfield · 2021-06-28T05:08:47Z

It's not an experiment anymore.

This still leaves one instance of the --enable-experiment flag for building web tests, which aren't fully migrated yet AFAICT.

dnfield · 2021-06-28T05:09:18Z

lib/snapshot/BUILD.gn

@@ -256,7 +256,6 @@ compile_platform("strong_platform") {
  is_runtime_mode_release =
      flutter_runtime_mode == "release" || flutter_runtime_mode == "jit_release"
  args = [
-    "--enable-experiment=non-nullable",


@jonahwilliams - adding --sound-null-safety fails here, but otherwise I think this works? I'm hoping you'll know if this is safe or not.

(same comment for the similar Fuchsia related targets for dart_runner and flutter)

Fuchsia currently does not have anything in the engine repo that compiles dart code. All of our tests are c++ unit tests and the targets are leftovers from when we moved out of topaz. We are in the process of adding some dart tests and there are some WIP cls that remove the old targets. I'll make sure that those get moved to sound null safety when they are added.

This is building the platform snapshot, not a test.

Like this:

FAILED: clang_x64/flutter_runner_patched_sdk/platform_strong.dill clang_x64/flutter_runner_patched_sdk/vm_outline_strong.dill python ../../third_party/dart/build/gn_run_binary.py compiled_action /b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/dart -Dsdk_hash=d2025958e3 --packages=/b/s/w/ir/cache/builder/src/third_party/dart/.packages --dfe=/b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot /b/s/w/ir/cache/builder/src/third_party/dart/pkg/front_end/tool/_fasta/compile_platform.dart --sound-null-safety --nnbd-agnostic --target=flutter_runner dart:core --single-root-scheme=org-dartlang-sdk --single-root-base=/b/s/w/ir/cache/builder/src/ org-dartlang-sdk:///flutter/shell/platform/fuchsia/flutter/kernel/libraries.json clang_x64/vm_outline_strong.dill clang_x64/flutter_runner_patched_sdk/platform_strong.dill clang_x64/flutter_runner_patched_sdk/vm_outline_strong.dill Command failed: /b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/dart -Dsdk_hash=d2025958e3 --packages=/b/s/w/ir/cache/builder/src/third_party/dart/.packages --dfe=/b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot /b/s/w/ir/cache/builder/src/third_party/dart/pkg/front_end/tool/_fasta/compile_platform.dart --sound-null-safety --nnbd-agnostic --target=flutter_runner dart:core --single-root-scheme=org-dartlang-sdk --single-root-base=/b/s/w/ir/cache/builder/src/ org-dartlang-sdk:///flutter/shell/platform/fuchsia/flutter/kernel/libraries.json clang_x64/vm_outline_strong.dill clang_x64/flutter_runner_patched_sdk/platform_strong.dill clang_x64/flutter_runner_patched_sdk/vm_outline_strong.dill output: Usage: compile_platform [options] dart-library-uri libraries.json vm_outline_strong.dill platform.dill outline.dill Compiles Dart SDK platform to the Dill/Kernel IR format. Frequently used options: -o <file> Generate the output into <file>. -h Display this message (add -v for information about all options). Error: Unknown option '--sound-null-safety'. [6735/7165] ACTION //flutter/shell/platform/fuchsia/flutter/kernel:kernel_platform_files(//build/toolchain/fuchsia:fuchsia) FAILED: flutter_runner_patched_sdk/platform_strong.dill flutter_runner_patched_sdk/vm_outline_strong.dill python ../../third_party/dart/build/gn_run_binary.py compiled_action /b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/dart -Dsdk_hash=d2025958e3 --packages=/b/s/w/ir/cache/builder/src/third_party/dart/.packages --dfe=/b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot /b/s/w/ir/cache/builder/src/third_party/dart/pkg/front_end/tool/_fasta/compile_platform.dart --sound-null-safety --nnbd-agnostic --target=flutter_runner dart:core --single-root-scheme=org-dartlang-sdk --single-root-base=/b/s/w/ir/cache/builder/src/ org-dartlang-sdk:///flutter/shell/platform/fuchsia/flutter/kernel/libraries.json vm_outline_strong.dill flutter_runner_patched_sdk/platform_strong.dill flutter_runner_patched_sdk/vm_outline_strong.dill Command failed: /b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/dart -Dsdk_hash=d2025958e3 --packages=/b/s/w/ir/cache/builder/src/third_party/dart/.packages --dfe=/b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot /b/s/w/ir/cache/builder/src/third_party/dart/pkg/front_end/tool/_fasta/compile_platform.dart --sound-null-safety --nnbd-agnostic --target=flutter_runner dart:core --single-root-scheme=org-dartlang-sdk --single-root-base=/b/s/w/ir/cache/builder/src/ org-dartlang-sdk:///flutter/shell/platform/fuchsia/flutter/kernel/libraries.json vm_outline_strong.dill flutter_runner_patched_sdk/platform_strong.dill flutter_runner_patched_sdk/vm_outline_strong.dill output: Usage: compile_platform [options] dart-library-uri libraries.json vm_outline_strong.dill platform.dill outline.dill Compiles Dart SDK platform to the Dill/Kernel IR format. Frequently used options: -o <file> Generate the output into <file>. -h Display this message (add -v for information about all options). Error: Unknown option '--sound-null-safety'.

(that's the fuchsia failure but the one here was the same)

Oh gotcha, I forgot about that. Is this failing because we are passing in a .packages file instead of a package_config.json?

It seems like Dart just doesn't like that argument there.

I'm going to split this one line into a separate patch and land the rest.

dnfield · 2021-06-28T05:09:50Z

testing/run_tests.py

@@ -221,8 +221,7 @@ def SnapshotTest(build_dir, test_packages, dart_file, kernel_file_output, verbos
    dart,
    '--disable-dart-dev',
    frontend_server,
-    '--enable-experiment=non-nullable',
-    '--no-sound-null-safety',
+    '--sound-null-safety',


VM tests are all migrated, this will fail on CI if there is any mistake.

yjbanov

LGTM if LGT @jonahwilliams

bdero · 2021-06-28T23:50:45Z

web_sdk/BUILD.gn

@@ -487,7 +487,7 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_outline_sound") {
  script = "//third_party/dart/utils/bazel/kernel_worker.dart"

  args = [
-    "--enable-experiment=non-nullable",
+    "--sound-null-safety",
    "--sound-null-safety",


Nit: Duplicate --sound-null-safety on 4 hunks in this file

…le (flutter/engine#26999)

…le (#26999)" This reverts commit 3283caf.

…le (#26999)" (#27059) This reverts commit 3283caf.

…le (flutter/engine#26999)

* 36a247f Temporarily opt out of reduced shaders variants till roll issues are resolved. (flutter/engine#27048) * b06ff83 [web] Render RTL text correctly (flutter/engine#26811) * 3283caf --sound-null-safety instead of enable-experiment where possible (flutter/engine#26999) * e10490d Roll Fuchsia Linux SDK from qq5J5tHIA... to eMHAbJpmO... (flutter/engine#27049) * 15ed6a0 Removes the licence sheck from cirrus (flutter/engine#27051) * 6d8a01a Roll Skia from 62ce2488f744 to c6804edbaefc (4 revisions) (flutter/engine#27050) * e8339ed Fix use-after-free. (flutter/engine#27053) * ecd4a14 Roll Dart SDK from 5103185fdff6 to 9d7c40ba84c4 (1 revision) (flutter/engine#27054) * 2e86f4b Roll Skia from c6804edbaefc to 55b401ed9e6c (1 revision) (flutter/engine#27055) * 6136cbd Give FlutterView a view ID (flutter/engine#27052) * 05fe2e2 Revert "--sound-null-safety instead of enable-experiment where possible (#26999)" (flutter/engine#27059) * c633b2a Roll Dart SDK from 9d7c40ba84c4 to d01a840fa25b (1 revision) (flutter/engine#27058)

…ter#26999)

…le (flutter#26999)" (flutter#27059) This reverts commit 3283caf.

…ter#26999)

…le (flutter#26999)" (flutter#27059) This reverts commit 3283caf.

No more experiments

d4be812

dnfield requested review from yjbanov and jonahwilliams June 28, 2021 05:08

flutter-dashboard bot added platform-fuchsia platform-web Code specifically for the web engine labels Jun 28, 2021

google-cla bot added the cla: yes label Jun 28, 2021

dnfield commented Jun 28, 2021

View reviewed changes

dnfield added 2 commits June 27, 2021 22:25

missing file

07b6f72

one more missing one

35855fc

dnfield requested a review from chaselatta June 28, 2021 16:51

yjbanov approved these changes Jun 28, 2021

View reviewed changes

dnfield mentioned this pull request Jun 28, 2021

Re-add annotations to test files that use null safety features #27021

Closed

bdero reviewed Jun 28, 2021

View reviewed changes

dnfield added 2 commits June 28, 2021 19:51

remove duplicate args

b75e2c4

revert removals

434772c

dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 29, 2021

fluttergithubbot merged commit 3283caf into flutter:master Jun 29, 2021

engine-flutter-autoroll mentioned this pull request Jun 30, 2021

Roll Engine from 9d2377f0d8aa to e8339ed2bd67 (7 revisions) flutter/flutter#85590

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2021

3283caf --sound-null-safety instead of enable-experiment where possib…

0bbf305

…le (flutter/engine#26999)

engine-flutter-autoroll mentioned this pull request Jun 30, 2021

Roll Engine from 9d2377f0d8aa to ecd4a14ab232 (8 revisions) flutter/flutter#85591

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2021

3283caf --sound-null-safety instead of enable-experiment where possib…

d65a298

…le (flutter/engine#26999)

dnfield added a commit that referenced this pull request Jun 30, 2021

Revert "--sound-null-safety instead of enable-experiment where possib…

22764a3

…le (#26999)" This reverts commit 3283caf.

dnfield mentioned this pull request Jun 30, 2021

Revert "--sound-null-safety instead of enable-experiment where possible" #27059

Merged

dnfield added a commit that referenced this pull request Jun 30, 2021

Revert "--sound-null-safety instead of enable-experiment where possib…

05fe2e2

…le (#26999)" (#27059) This reverts commit 3283caf.

engine-flutter-autoroll mentioned this pull request Jun 30, 2021

Roll Engine from 9d2377f0d8aa to 6136cbd8b054 (10 revisions) flutter/flutter#85595

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2021

3283caf --sound-null-safety instead of enable-experiment where possib…

2f4db00

…le (flutter/engine#26999)

engine-flutter-autoroll mentioned this pull request Jun 30, 2021

Roll Engine from 9d2377f0d8aa to c633b2a6a04f (12 revisions) flutter/flutter#85598

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2021

3283caf --sound-null-safety instead of enable-experiment where possib…

b2a8ad2

…le (flutter/engine#26999)

moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021

--sound-null-safety instead of enable-experiment where possible (flut…

ebe95b0

…ter#26999)

moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021

Revert "--sound-null-safety instead of enable-experiment where possib…

2138df4

…le (flutter#26999)" (flutter#27059) This reverts commit 3283caf.

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

--sound-null-safety instead of enable-experiment where possible (flut…

3a9da4b

…ter#26999)

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021

Revert "--sound-null-safety instead of enable-experiment where possib…

3dc2880

…le (flutter#26999)" (flutter#27059) This reverts commit 3283caf.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

--sound-null-safety instead of enable-experiment where possible #26999

--sound-null-safety instead of enable-experiment where possible #26999

Uh oh!

dnfield commented Jun 28, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

chaselatta Jun 28, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

jonahwilliams Jun 28, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

chaselatta Jun 28, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

dnfield Jun 29, 2021

Uh oh!

dnfield Jun 28, 2021

Uh oh!

yjbanov left a comment

Uh oh!

bdero Jun 28, 2021

Uh oh!

dnfield Jun 29, 2021

Uh oh!

Uh oh!

--sound-null-safety instead of enable-experiment where possible #26999

--sound-null-safety instead of enable-experiment where possible #26999

Uh oh!

Conversation

dnfield commented Jun 28, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!