This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Render RTL text correctly #26811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
commented
Jun 23, 2021
yjbanov
reviewed
Jun 23, 2021
|
|
||
| LineBreakType get type => lineBreak.type; | ||
|
|
||
| /// Creates a copy of this [DirectionalPosition] with a different [index]. |
There was a problem hiding this comment.
and LineBreakType.prohibited.
Speaking of which, why does it unconditionally set prohibited?
There was a problem hiding this comment.
By default, we don't want to break anywhere, except where nextLineBreak() says it's ok to break.
| l('baz', 8, 11, hardBreak: true, width: 30.0, left: 0.0, height: 10.0, baseline: 18.0), | ||
| ]); | ||
| }); | ||
| // test('no text', () { |
There was a problem hiding this comment.
What's the plan for these tests?
There was a problem hiding this comment.
Whoops! They should be fine. I just forgot to uncomment them.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
bdero
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2021
* 36a247f Temporarily opt out of reduced shaders variants till roll issues are resolved. (flutter/engine#27048) * b06ff83 [web] Render RTL text correctly (flutter/engine#26811) * 3283caf --sound-null-safety instead of enable-experiment where possible (flutter/engine#26999) * e10490d Roll Fuchsia Linux SDK from qq5J5tHIA... to eMHAbJpmO... (flutter/engine#27049) * 15ed6a0 Removes the licence sheck from cirrus (flutter/engine#27051) * 6d8a01a Roll Skia from 62ce2488f744 to c6804edbaefc (4 revisions) (flutter/engine#27050) * e8339ed Fix use-after-free. (flutter/engine#27053) * ecd4a14 Roll Dart SDK from 5103185fdff6 to 9d7c40ba84c4 (1 revision) (flutter/engine#27054) * 2e86f4b Roll Skia from c6804edbaefc to 55b401ed9e6c (1 revision) (flutter/engine#27055) * 6136cbd Give FlutterView a view ID (flutter/engine#27052) * 05fe2e2 Revert "--sound-null-safety instead of enable-experiment where possible (#26999)" (flutter/engine#27059) * c633b2a Roll Dart SDK from 9d7c40ba84c4 to d01a840fa25b (1 revision) (flutter/engine#27058)
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
justinmc
added a commit
to justinmc/engine
that referenced
this pull request
Sep 9, 2021
This reverts commit b06ff83.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement handling of bidi text in the html renderer.
Goldens: flutter/goldens#205
Golden updates: flutter/goldens#210
Fixes flutter/flutter#69396
Fixes flutter/flutter#32239
Fixes flutter/flutter#78550
Fixes flutter/flutter#82136