This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Make drain() consistently asynchronous." #21391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cdc631c.
Contributor
Author
|
cc @gaaclarke for review. |
gaaclarke
approved these changes
Sep 24, 2020
Contributor
Author
|
We should land this if we determine that flutter/flutter#66073 has landed in google's codebase and that the original engine PR here is still causing issues. If landing flutter/flutter#66073 fixes google's issues then this can be closed without landing. |
Contributor
|
I have confirmed the flutter/flutter#66073 is landed in google already. I double checked and the test still fails. See b/169314044. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2020
Contributor
Author
|
Follow-up in flutter/flutter#66699. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #21062, which caused a hang in a google3 test.