This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make drain() consistently asynchronous. #21062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
commented
Sep 9, 2020
Hixie
force-pushed
the
drain
branch
2 times, most recently
from
083ae23 to
b3e48ce
Compare
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Sep 10, 2020
…ation. Having side-effects in a getter is surprising and unintuitive. This reduces the side-effects caused by RestorationManager.rootBucket. Also, flutter/engine#21062 is planning on making the message queue draining asynchronous, so we need to make sure that we subscribe to messages before the build phase is scheduled, otherwise we will be delaying the first frame by one cycle.
Contributor
Author
|
Test failures will be addressed by flutter/flutter#65579 |
Hixie
force-pushed
the
drain
branch
3 times, most recently
from
d3c06e2 to
2fbea64
Compare
Contributor
Author
|
This is blocked because it exposes a number of issues with ChannelBuffers that result in an infinite loop in one of the framework tests.
We could avoid all of these by removing the concept of a ring buffer (flutter/flutter#66071), but that's a potentially very breaking change. |
Contributor
Author
|
flutter/flutter#66073 probably unblocks this enough for now. |
Contributor
Author
|
cc @gaaclarke @yjbanov This is ready for review now, with the framework-side changes having landed. |
gaaclarke
approved these changes
Sep 23, 2020
Hixie
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2020
renyou
pushed a commit
that referenced
this pull request
Sep 25, 2020
Contributor
Author
|
This failed in google3, will follow-up in flutter/flutter#66699. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.