Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Removed a text input trait that causes VoiceOver to be incorrect when tapping a text input. #17203

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Removed a text input trait that causes VoiceOver to be incorrect when tapping a text input. #17203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions shell/platform/darwin/ios/framework/Source/accessibility_text_entry.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
#include "flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.h"
#include "flutter/shell/platform/darwin/ios/framework/Source/accessibility_text_entry.h"

static const UIAccessibilityTraits UIAccessibilityTraitUndocumentedEmptyLine = 0x800000000000;

@implementation FlutterInactiveTextInput {
}

Expand Down Expand Up @@ -284,8 +286,13 @@ - (UIAccessibilityTraits)accessibilityTraits {
// Adding UIAccessibilityTraitKeyboardKey to the trait list so that iOS treats it like
// a keyboard entry control, thus adding support for text editing features, such as
// pinch to select text, and up/down fling to move cursor.
return [super accessibilityTraits] | [self textInputSurrogate].accessibilityTraits |
UIAccessibilityTraitKeyboardKey;
UIAccessibilityTraits results = [super accessibilityTraits] |
[self textInputSurrogate].accessibilityTraits |
UIAccessibilityTraitKeyboardKey;
// We remove an undocumented flag to get rid of a bug where single-tapping
// a text input field incorrectly says "empty line".
// See also: https://github.com/flutter/flutter/issues/52487
return results & (~UIAccessibilityTraitUndocumentedEmptyLine);
}

#pragma mark - UITextInput overrides
Expand Down