This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Removed a text input trait that causes VoiceOver to be incorrect when tapping a text input. #17203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapping a text input.
goderbauer
reviewed
Mar 20, 2020
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM as long as this doesn't break anything with regards to a11y text input.
I wish we would know what this trait does.
Member
Author
|
triple checked this, merging |
Member
|
Thanks for handling this @gaaclarke |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
…ect when tapping a text input. (flutter/engine#17203)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
…ect when tapping a text input. (flutter/engine#17203)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2020
…ect when tapping a text input. (flutter/engine#17203)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant issue: flutter/flutter#52487