Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@iskakaushik
Copy link
Contributor

This is to address fxb/44063

In all the other modes they will be sent to the systrace

@auto-assign auto-assign bot requested a review from stuartmorgan-g January 22, 2020 23:08
@iskakaushik iskakaushik removed the request for review from stuartmorgan-g January 22, 2020 23:09
This is to address fxb/44063

In all the other modes they will be sent to the systrace
@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 23, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Cirrus CI has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 23, 2020
@iskakaushik iskakaushik merged commit 5c9c627 into flutter:master Jan 23, 2020
@iskakaushik iskakaushik deleted the fxb_44063 branch January 23, 2020 19:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 24, 2020
flutter/engine@46e58b9...439a218

git log 46e58b9..439a218 --first-parent --oneline
2020-01-23 zhongwuzw@qq.com Fixes labelPrefix memory leak in FlutterEngine (flutter/engine#14674)
2020-01-23 matthew-carroll@users.noreply.github.com Release TextureView surface within FlutterTextureView when disconnected. (#48535) (flutter/engine#15899)
2020-01-23 iska.kaushik@gmail.com [fuchsia] Timeline events in profile mode to observatory (flutter/engine#15900)
2020-01-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from N502w... to Wc7e4... (flutter/engine#15935)
2020-01-23 tvolkert@users.noreply.github.com Add script to force build LUCI builders for a specified commit (flutter/engine#15938)
2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 6aa7407d6309..e84bea25df23 (6 commits) (flutter/engine#15934)
2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia f9aea7f7e502..e4ddb8a7cddc (35 commits) (flutter/engine#15931)
2020-01-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from LGwl3... to LAOYs... (flutter/engine#15930)
2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 582727a4ec3b..6aa7407d6309 (4 commits) (flutter/engine#15923)
2020-01-23 gw280@google.com Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (#15118)" (flutter/engine#15903)
2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart a9ea9365ad8a..582727a4ec3b (33 commits) (flutter/engine#15906)
2020-01-22 brianosman@google.com Implement new SkCanvas virtuals in testing canvases (flutter/engine#15893)
2020-01-22 dnfield@google.com Const finder fixes (flutter/engine#15880)
2020-01-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v-OJE... to N502w... (flutter/engine#15892)
2020-01-22 dnfield@google.com errant log (flutter/engine#15891)
2020-01-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia d59053987a27..f9aea7f7e502 (10 commits) (flutter/engine#15890)
2020-01-22 jason-simmons@users.noreply.github.com [libtxt] Assign a unique ID to each glyph cluster within a line (flutter/engine#15742)
2020-01-22 skia-flutter-autoroll@skia.org Roll src/third_party/dart 439cabaec02f..a9ea9365ad8a (4 commits) (flutter/engine#15886)
2020-01-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jAkm1... to LGwl3... (flutter/engine#15884)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
This is to address fxb/44063

In all the other modes they will be sent to the systrace
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
nathanrogersgoogle added a commit that referenced this pull request Sep 3, 2020
…20974)

This change reverts #15900.  The
design of the expected consumer of the original PR changed, and the
feature ended up going unused.  Since the unexpected difference in trace
event routing behavior has mostly ended up as a source of confusion,
change things back to route trace events to Fuchsia system tracing on
all configurations.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants