[fuchsia] Timeline events in profile mode to observatory (#15900)

iskakaushik · web-flow · commit 5c9c6276c14c · 2020-01-23T11:53:03.000-08:00
This is to address fxb/44063

In all the other modes they will be sent to the systrace
diff --git a/runtime/dart_vm.cc b/runtime/dart_vm.cc
@@ -380,7 +380,8 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
     args.push_back(old_gen_heap_size_args.c_str());
   }
 
-#if defined(OS_FUCHSIA)
+#if defined(OS_FUCHSIA) && \
+    (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_PROFILE)
   PushBackAll(&args, kDartFuchsiaTraceArgs, fml::size(kDartFuchsiaTraceArgs));
   PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs));
 #endif
diff --git a/shell/platform/fuchsia/dart_runner/dart_runner.cc b/shell/platform/fuchsia/dart_runner/dart_runner.cc
@@ -39,7 +39,9 @@ const char* kDartVMArgs[] = {
     // addressed.
     "--no_causal_async_stacks",
 
+#if !defined(FLUTTER_PROFILE)
     "--systrace_timeline",
+#endif
     "--timeline_streams=Compiler,Dart,Debugger,Embedder,GC,Isolate,VM",
 
 #if defined(AOT_RUNTIME)

Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,8 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,`
`380`	`380`	`args.push_back(old_gen_heap_size_args.c_str());`
`381`	`381`	`}`
`382`	`382`
`383`		`-#if defined(OS_FUCHSIA)`
	`383`	`+#if defined(OS_FUCHSIA) && \`
	`384`	`+ (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_PROFILE)`
`384`	`385`	`PushBackAll(&args, kDartFuchsiaTraceArgs, fml::size(kDartFuchsiaTraceArgs));`
`385`	`386`	`PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs));`
`386`	`387`	`#endif`