This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. #12746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Oct 2, 2019
| // it has changed since the last update. | ||
| if (inputFocusedSemanticsNode != null && inputFocusedSemanticsNode.id == object.id && | ||
| (lastInputFocusedSemanticsNode == null || lastInputFocusedSemanticsNode.id != inputFocusedSemanticsNode.id)) { | ||
| lastInputFocusedSemanticsNode = inputFocusedSemanticsNode; |
There was a problem hiding this comment.
nit: the indentation here is strange making it hard to see where the condition ends and where the body of the if starts.
gspencergoog
force-pushed
the
focus_accessibility
branch
from
931c9eb to
ebd42c6
Compare
cbracken
approved these changes
Oct 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2019
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224 git log c635d70..21b8224 --no-merges --oneline 2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746) 2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter/engine#12990) 2019-10-08 katelovett@google.com Link Semantics Typo (flutter/engine#13009) 2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter/engine#12794) 2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter/engine#13005) 2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter/engine#12813) 2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter/engine#13003) 2019-10-08 katelovett@google.com Missing link flag (flutter/engine#13001) 2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter/engine#12999) 2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224 git log c635d70..21b8224 --no-merges --oneline 2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746) 2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter/engine#12990) 2019-10-08 katelovett@google.com Link Semantics Typo (flutter/engine#13009) 2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter/engine#12794) 2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter/engine#13005) 2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter/engine#12813) 2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter/engine#13003) 2019-10-08 katelovett@google.com Missing link flag (flutter/engine#13001) 2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter/engine#12999) 2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the focus changes, we should be sending a TYPE_VIEW_FOCUSED event. This enables that.