Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Missing link flag #13001

Merged
merged 16 commits into from
Oct 8, 2019
Merged

Missing link flag #13001

merged 16 commits into from
Oct 8, 2019

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 8, 2019

Adds missing semantics flag for web. :)
Related to #12972 and #12453.

Framework counter PR: flutter/flutter#41327 - will require a manual engine roll.

Part of flutter/flutter#36306

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Contributor Author

Piinks commented Oct 8, 2019

Landing on red to manually roll with flutter/flutter#41327

@Piinks Piinks merged commit 414ad38 into flutter:master Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 9, 2019
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224

git log c635d70..21b8224 --no-merges --oneline
2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746)
2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter/engine#12990)
2019-10-08 katelovett@google.com Link Semantics Typo (flutter/engine#13009)
2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter/engine#12794)
2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter/engine#13005)
2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter/engine#12813)
2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter/engine#13003)
2019-10-08 katelovett@google.com Missing link flag (flutter/engine#13001)
2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter/engine#12999)
2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
dnfield pushed a commit to dnfield/engine that referenced this pull request Oct 9, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
git@github.com:flutter/engine.git/compare/c635d70c7266...21b8224

git log c635d70..21b8224 --no-merges --oneline
2019-10-08 gspencergoog@users.noreply.github.com Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746)
2019-10-08 dnfield@google.com Fix for a11y crash on iOS (flutter/engine#12990)
2019-10-08 katelovett@google.com Link Semantics Typo (flutter/engine#13009)
2019-10-08 ferhat@gmail.com [web] Add support for path transform (flutter/engine#12794)
2019-10-08 jason-simmons@users.noreply.github.com Auto-formatter fixes for BUILD.gn files (flutter/engine#13005)
2019-10-08 bkonyi@google.com Unblock SIGPROF on flutter_tester start (flutter/engine#12813)
2019-10-08 mouad.debbar@gmail.com [web] Update the url when route is replaced (flutter/engine#13003)
2019-10-08 katelovett@google.com Missing link flag (flutter/engine#13001)
2019-10-08 30870216+gaaclarke@users.noreply.github.com Started setting our debug background task id to invalid after completion. (flutter/engine#12999)
2019-10-08 ychris@google.com Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants