Skip to content

app_shared: migrate to pkg:web #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

app_shared: migrate to pkg:web #6577

wants to merge 3 commits into from

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Oct 23, 2023 •
edited
Loading

No description provided.

@kevmoo kevmoo requested a review from a team as a code owner October 23, 2023 21:46
@kevmoo kevmoo requested review from kenzieschmoll and removed request for a team October 23, 2023 21:46
@kevmoo kevmoo force-pushed the app_shared_pkg_web branch from 9bc3517 to db505b0 Compare October 23, 2023 21:46
@kevmoo kevmoo changed the title app shared pkg web app_shared: migrate to pkg:web Oct 23, 2023
kenzieschmoll
kenzieschmoll reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changelog entry to devtools_app_shared under 0.0.7? thanks

@kevmoo
Copy link
Contributor Author

kevmoo commented Oct 23, 2023

can you add a changelog entry to devtools_app_shared under 0.0.7? thanks

Done!

@kevmoo
Copy link
Contributor Author

kevmoo commented Oct 26, 2023

@kenzieschmoll – PTAL!

@kevmoo kevmoo mentioned this pull request Oct 26, 2023
Closed
7 tasks
@kevmoo kevmoo force-pushed the app_shared_pkg_web branch from bea508e to dbd43a5 Compare October 30, 2023 19:45
@kenzieschmoll
Copy link
Member

If you merge master, this should go green and we can land this change.

@kevmoo kevmoo force-pushed the app_shared_pkg_web branch from dbd43a5 to f6f8659 Compare October 31, 2023 20:16
@kevmoo
Copy link
Contributor Author

kevmoo commented Oct 31, 2023

This is now subsumed by #6626

@kevmoo kevmoo closed this Oct 31, 2023
@kevmoo kevmoo deleted the app_shared_pkg_web branch October 31, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @kenzieschmoll