Work towards migrating devtools_app to package:web
#6626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujzs
reviewed
Oct 31, 2023
packages/devtools_app/lib/src/extensions/embedded/_view_web.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/extensions/embedded/_view_web.dart
Outdated
Show resolved
Hide resolved
| @@ -166,7 +165,7 @@ class PerfettoControllerImpl extends PerfettoController { | |||
| ); | |||
| _initialized = true; | |||
|
|
|||
| _perfettoIFrame = html.IFrameElement() | |||
| _perfettoIFrame = createElementTag('iframe') as HTMLIFrameElement | |||
There was a problem hiding this comment.
Note that this cast is okay in contrast with the cast above. You're casting between interop types and you know it's that type. I think this isn't a lint in the future with extension types.
...s/devtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_web.dart
Outdated
Show resolved
Hide resolved
...s/devtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_web.dart
Outdated
Show resolved
Hide resolved
...tools_app/lib/src/shared/config_specific/framework_initialize/_framework_initialize_web.dart
Outdated
Show resolved
Hide resolved
...ensions/lib/src/template/_simulated_devtools_environment/_simulated_devtools_controller.dart
Outdated
Show resolved
Hide resolved
...ensions/lib/src/template/_simulated_devtools_environment/_simulated_devtools_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_extensions/lib/src/template/extension_manager.dart
Outdated
Show resolved
Hide resolved
packages/devtools_extensions/lib/src/template/extension_manager.dart
Outdated
Show resolved
Hide resolved
CoderDake
approved these changes
Oct 31, 2023
packages/devtools_app/lib/src/shared/config_specific/notifications/_notifications_web.dart
Show resolved
Hide resolved
kevmoo
approved these changes
Nov 1, 2023
srujzs
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates most of
devtools_appto usepackage:web. There are a handful of remaining uses to migrate that are not straightforward or wherepackage:webis missing some getters. I documented those on #6606.I also cleaned up some of the conditional imports while I was here (renaming files, removing unnecessary stub files, etc.).