Store an instance to console #5049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/sampler.dart
Show resolved
Hide resolved
Comment on lines
+46
to
+57
| final response1 = await serviceManager.service! | ||
| .evaluate(isolateId, instance.id!, 'toString()'); | ||
| print('!!!! eval without scope: ' + response1.json!['valueAsString']); | ||
|
|
||
| // eval object | ||
| final response2 = await serviceManager.service!.evaluate( | ||
| isolateId, | ||
| instance.id!, | ||
| 'identityHashCode(this)', | ||
| scope: {'this': instance.id!}, | ||
| ); | ||
| print('!!!! eval with scope: ' + response2.json!['valueAsString']); |
There was a problem hiding this comment.
are these supposed to still be there? both the responses and the prints?
There was a problem hiding this comment.
they are under TODO to move them out
|
|
||
| @override | ||
| final HeapClassName heapClass; | ||
| }) : super(objectsByPath, heapClass); |
There was a problem hiding this comment.
these can both be super parameters in the constructor directly
DiffClassStats._({
required super.heapClass,
required super.objectsByPath,
required this.total,
})
| sampleObtainer, | ||
| ), | ||
| const MenuItemButton( | ||
| child: Text('Browse an instance in console'), |
There was a problem hiding this comment.
maybe this should mention the work "references" to make it clear what you can browse
|
Addressed the comments in #5053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_NOTE_EXCEPTION=[under flag]