Store an instance and its references to console #5053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import '../../../../shared/analytics/constants.dart'; | ||
| import '../../../../shared/common_widgets.dart'; | ||
| import '../../../../shared/primitives/utils.dart'; | ||
|
|
||
| typedef SampleObtainer = InstanceRef Function(); | ||
| abstract class ClassSampler { |
There was a problem hiding this comment.
why do we need an abstract class for this? will there be another class that extends ClassSampler at some point?
There was a problem hiding this comment.
Yes, table that diffs snapshots, will need another implementation.
packages/devtools_app/lib/src/shared/console/console_service.dart
Outdated
Show resolved
Hide resolved
| ), | ||
| MenuItemButton( | ||
| onPressed: sampleObtainer.instanceGraphToConsole, | ||
| child: const Text('Browse an instance references in console'), |
There was a problem hiding this comment.
This wording could use a little work. Maybe "Browser references for a single instance"
There was a problem hiding this comment.
Made it 'Browse references for a single instance in console'
I want the word 'console', because without it user will not pay attention to console and will miss what is going on.
kenzieschmoll
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE_NOTE_EXCEPTION=[under the flag]