bring the packages's lints in-line with the Flutter standard #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Aug 20, 2018
lib/performance/performance.dart
Outdated
| @@ -397,7 +407,11 @@ tries['inclusiveFunctionTrie'] = | |||
| */ | |||
|
|
|||
| int clamp(int value, int min, int max) { | |||
| if (value < min) return min; | |||
| if (value > max) return max; | |||
| if (value < min) { | |||
There was a problem hiding this comment.
nit: int now has a clamp method. in a separate CL perhaps switch to it instead.
https://api.dartlang.org/stable/2.0.0/dart-core/num/clamp.html
There was a problem hiding this comment.
ah, I was not aware; switched over to using this
jacob314
approved these changes
Aug 20, 2018
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Dec 14, 2024
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Dec 18, 2024
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Dec 20, 2024
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 6, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 7, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 7, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 13, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 13, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 14, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 15, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 16, 2025
mossmana
added a commit
to mossmana/devtools
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jacob314