Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 10, 2022

iOS arm7v is no longer built as of flutter/flutter#97342. Fixes flutter/flutter#97345

See also #262

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this May 10, 2022
@jmagman jmagman requested a review from zanderso May 10, 2022 23:01
@jmagman jmagman merged commit c865293 into flutter:master May 12, 2022
@jmagman jmagman deleted the remove-armv7 branch May 12, 2022 21:30
@jmagman
Copy link
Member Author

jmagman commented May 12, 2022

Will roll this in after flutter/engine#33284 is done.

auto-submit bot pushed a commit to flutter/engine that referenced this pull request Jul 16, 2024
We dropped support for armv7 iOS devices in:
* Framework: flutter/flutter#97342.
* Buildroot: flutter/buildroot#569
* Engine: #32664
* Recipes:
  * https://flutter-review.googlesource.com/c/recipes/+/29060
  * https://flutter-review.googlesource.com/c/recipes/+/29060 (revert)
  * https://flutter-review.googlesource.com/c/recipes/+/29582 (reland)
* Issue: flutter/flutter#97345

This eliminates the code (and an unused flag) to deal with producing zip archives including components for the armv7 architecture.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove arm7v iOS logic from buildroot

2 participants