Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5b9fc4e

Browse files
authored
[iOS] Delete gen_snapshot_armv7 support (#53947)
We dropped support for armv7 iOS devices in: * Framework: flutter/flutter#97342. * Buildroot: flutter/buildroot#569 * Engine: #32664 * Recipes: * https://flutter-review.googlesource.com/c/recipes/+/29060 * https://flutter-review.googlesource.com/c/recipes/+/29060 (revert) * https://flutter-review.googlesource.com/c/recipes/+/29582 (reland) * Issue: flutter/flutter#97345 This eliminates the code (and an unused flag) to deal with producing zip archives including components for the armv7 architecture. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent dabc187 commit 5b9fc4e

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

sky/tools/create_ios_framework.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def main():
2424

2525
parser.add_argument('--dst', type=str, required=True)
2626
parser.add_argument('--arm64-out-dir', type=str, required=True)
27-
parser.add_argument('--armv7-out-dir', type=str, required=False)
2827
# TODO(gw280): Remove --simulator-out-dir alias when all recipes are updated
2928
parser.add_argument('--simulator-x64-out-dir', '--simulator-out-dir', type=str, required=True)
3029
parser.add_argument('--simulator-arm64-out-dir', type=str, required=False)

sky/tools/create_macos_gen_snapshots.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ def main():
2121
parser.add_argument('--clang-dir', type=str, default='clang_x64')
2222
parser.add_argument('--x64-out-dir', type=str)
2323
parser.add_argument('--arm64-out-dir', type=str)
24-
parser.add_argument('--armv7-out-dir', type=str)
2524
parser.add_argument('--zip', action='store_true', default=False)
2625

2726
args = parser.parse_args()
@@ -48,14 +47,6 @@ def main():
4847
os.path.join(arm64_out_dir, args.clang_dir), os.path.join(dst, 'gen_snapshot_arm64')
4948
)
5049

51-
if args.armv7_out_dir:
52-
armv7_out_dir = (
53-
args.armv7_out_dir
54-
if os.path.isabs(args.armv7_out_dir) else os.path.join(buildroot_dir, args.armv7_out_dir)
55-
)
56-
generate_gen_snapshot(
57-
os.path.join(armv7_out_dir, args.clang_dir), os.path.join(dst, 'gen_snapshot_armv7')
58-
)
5950
if args.zip:
6051
zip_archive(dst)
6152

0 commit comments

Comments
 (0)