Skip to content

[webview_flutter] Apply PlatformView's Intreface #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented Jul 9, 2021

Now, This PR only contains PlatformView's Intreface change.

@swift-kim
Copy link
Member

This package is an immediate successor of webview_flutter_tizen, right? Shouldn't we just change the directory name (webview_flutter to webview_flutter_lwe) and discontinue the original package instead of copying all the files and maintaining two sets of source code?

pub.dev admin option:

image

Also you need to update README in the root of this repo.

Also since there has been a breaking change in the PlatformView API (flutter-tizen/engine#136), please let me know when this PR is ready for merge so that I can create an engine release.

@bwikbs
Copy link
Member Author

bwikbs commented Jul 12, 2021

As we discussed, It's decided to keep the existing packages and only add ewk webview.
Now this PR contains only interface changes.

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs bwikbs changed the title [webview_flutter] Introduce webview_flutter_tizen_lwe package [webview_flutter] Apply PlatformView's Intreface Jul 13, 2021
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Copy link
Member Author

bwikbs commented Jul 14, 2021

please let me know when this PR is ready for merge so that I can create an engine release.

@swift-kim Now, It's ready I guess

@swift-kim
Copy link
Member

@bwikbs I'll not be at the office until tomorrow, so could you do some ad hoc testing (like running simple apps on various devices including watch/watch emulator/TV) of the current latest engine before publishing a release?

@bwikbs
Copy link
Member Author

bwikbs commented Jul 14, 2021

@swift-kim Sure, no problem!
BTW, flutter-tizen/engine#142 include breaking change also.
So based on that I will update and test this PR

bwikbs added 2 commits July 15, 2021 09:31
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Copy link
Member Author

bwikbs commented Jul 15, 2021

I've tested webview example & hello world. ( include flutter-tizen/engine#142)
Here is result:

  • TM1
  • FHUB
  • Watch3( webview /w wayland backend)
  • TV (eng)

@swift-kim
Copy link
Member

@bwikbs Thanks. You don't have to take too much time for testing. It's just for finding major bugs like app not launching properly.

@bbrto21 bbrto21 merged commit 3918e15 into flutter-tizen:master Jul 19, 2021
bwikbs added a commit to bwikbs/plugins that referenced this pull request Jul 19, 2021
* This is missing part of flutter-tizen#146

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
bbrto21 pushed a commit that referenced this pull request Jul 19, 2021
* This is missing part of #146

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants