-
Notifications
You must be signed in to change notification settings - Fork 51
[webview_flutter] Apply PlatformView's Intreface #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This package is an immediate successor of webview_flutter_tizen, right? Shouldn't we just change the directory name ( pub.dev admin option: Also you need to update README in the root of this repo. Also since there has been a breaking change in the PlatformView API (flutter-tizen/engine#136), please let me know when this PR is ready for merge so that I can create an engine release. |
As we discussed, It's decided to keep the existing packages and only add ewk webview. |
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@swift-kim Now, It's ready I guess |
@bwikbs I'll not be at the office until tomorrow, so could you do some ad hoc testing (like running simple apps on various devices including watch/watch emulator/TV) of the current latest engine before publishing a release? |
@swift-kim Sure, no problem! |
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
I've tested webview example & hello world. ( include flutter-tizen/engine#142)
|
@bwikbs Thanks. You don't have to take too much time for testing. It's just for finding major bugs like app not launching properly. |
* This is missing part of flutter-tizen#146 Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* This is missing part of #146 Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Now, This PR only contains PlatformView's Intreface change.