Refactor TextInputChannel #142

bbrto21 · 2021-07-13T10:40:39Z

Introduce TizenInputMethodContext
Do not handle key event for PlatformView in TextInputChannel
Each PlatformView must Implement to handle key event.
After this patch, the input panel of webview_flutter does not work properly.
but it have to handle every key event on itself like webview_flutter_ewk does.

Signed-off-by: Boram Bae boram21.bae@samsung.com

* Introduce TizenInputMethodContext * Do not handle key event for PlatformView in TextInputChannel Each PlatformView must Implement to handle key event. After this patch, the input panel of webview_flutter does not work properly. but it have to handle every key event on itself like webview_flutter_ewk does. Signed-off-by: Boram Bae <boram21.bae@samsung.com>

bwikbs · 2021-07-14T01:47:07Z

  void DispatchCompositionUpdateEvent(const std::string& key);
  void DispatchCompositionEndEvent(const std::string& key);

Is this intentional? Shouldn't we remove this?

bbrto21 · 2021-07-14T02:03:45Z

  void DispatchCompositionUpdateEvent(const std::string& key);
  void DispatchCompositionEndEvent(const std::string& key);

Is this intentional? Shouldn't we remove this?

Yes, the text composition of the PlatformView must be independent of the TextInputChannel.
IMHO, I think these interfaces are unnecessary.

bwikbs · 2021-07-14T02:06:17Z

If we don't need it, how about removing it this time? We need a engine release because of the platformview interface change , so let's do it together.

bbrto21 · 2021-07-14T04:16:11Z

If we don't need it, how about removing it this time? We need a engine release because of the platformview interface change , so let's do it together.

I will remove it immediately.

shell/platform/tizen/channels/platform_view_channel.h

swift-kim · 2021-07-14T04:21:28Z

shell/platform/tizen/key_event_handler.cc

  if (engine->text_input_channel) {
-    if (is_down) {
+    if (is_down && engine->text_input_channel->IsSoftwareKeyboardShowing()) {
      engine->text_input_channel->OnKeyDown(key);
-    }
-    if (engine->text_input_channel->IsSoftwareKeyboardShowing()) {
      return ECORE_CALLBACK_PASS_ON;
    }
  }


The text input channel only handles the key event when the software keyboard is shown?

Well... strictly, I should say no, If the TextInputModel is valid, it can handle key-event.
It is created when TextInputChannel receives TextInput.setClient as a message.
(The message for showing the keyboard is TextInput.show.)

How about this?

Mmmm. You have to carefully see how the original logic looks like. It skips sending a key event to key_event_channel only when the software keyboard is shown.

I think... it's changed a bit, but the behavior hasn't changed much.

shell/platform/tizen/tizen_input_method_context.cc

shell/platform/tizen/tizen_input_method_context.h

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

* Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <boram21.bae@samsung.com>

bbrto21 · 2021-07-14T06:43:56Z

I will remove it immediately.

@bwikbs
Please, review again

bwikbs

Please, review again

Thanks! 👍

shell/platform/tizen/channels/text_input_channel.cc

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

* Refactor TextInputChannel * Introduce TizenInputMethodContext * Do not handle key event for PlatformView in TextInputChannel Each PlatformView must Implement to handle key event. After this patch, the input panel of webview_flutter does not work properly. but it have to handle every key event on itself like webview_flutter_ewk does. Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Remove unnecessary PlatformView APIs Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Tidy up based on review Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Always Send key event to TextInputChannel * Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Use #if defined() instead of #ifdef Signed-off-by: Boram Bae <boram21.bae@samsung.com> * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <boram21.bae@samsung.com>

* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <boram21.bae@samsung.com>

swift-kim reviewed Jul 14, 2021

View reviewed changes

bbrto21 added 3 commits July 14, 2021 14:20

Remove unnecessary PlatformView APIs

3f5aace

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

Tidy up based on review

a5fb117

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

Always Send key event to TextInputChannel

07d2c1a

* Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <boram21.bae@samsung.com>

bwikbs approved these changes Jul 14, 2021

View reviewed changes

bwikbs mentioned this pull request Jul 14, 2021

[webview_flutter] Apply PlatformView's Intreface flutter-tizen/plugins#146

Merged

swift-kim reviewed Jul 15, 2021

View reviewed changes

bbrto21 added 2 commits July 15, 2021 12:59

Use #if defined() instead of #ifdef

d4328a8

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

Rename to ShouldNotFilterEvent

7350d15

Signed-off-by: Boram Bae <boram21.bae@samsung.com>

swift-kim approved these changes Jul 15, 2021

View reviewed changes

swift-kim merged commit 6280c13 into flutter-tizen:flutter-2.2.1-tizen Jul 15, 2021

swift-kim mentioned this pull request May 11, 2022

[webview_flutter] Refactor the C++ code flutter-tizen/plugins#383

Merged

swift-kim pushed a commit that referenced this pull request Sep 1, 2022

Implement mask blur in display list dispatcher (#142)

f86c9b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor TextInputChannel #142

Refactor TextInputChannel #142

Uh oh!

bbrto21 commented Jul 13, 2021

Uh oh!

bwikbs commented Jul 14, 2021

Uh oh!

bbrto21 commented Jul 14, 2021

Uh oh!

bwikbs commented Jul 14, 2021

Uh oh!

bbrto21 commented Jul 14, 2021

Uh oh!

Uh oh!

swift-kim Jul 14, 2021

Uh oh!

bbrto21 Jul 14, 2021

Uh oh!

bbrto21 Jul 14, 2021

Uh oh!

swift-kim Jul 14, 2021

Uh oh!

bbrto21 Jul 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbrto21 commented Jul 14, 2021

Uh oh!

bwikbs left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Refactor TextInputChannel #142

Refactor TextInputChannel #142

Uh oh!

Conversation

bbrto21 commented Jul 13, 2021

Uh oh!

bwikbs commented Jul 14, 2021

Uh oh!

bbrto21 commented Jul 14, 2021

Uh oh!

bwikbs commented Jul 14, 2021

Uh oh!

bbrto21 commented Jul 14, 2021

Uh oh!

Uh oh!

swift-kim Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

bbrto21 Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

bbrto21 Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

swift-kim Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

bbrto21 Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbrto21 commented Jul 14, 2021

Uh oh!

bwikbs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!