Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added a test filter for objc tests - #27566

Merged
fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
gaaclarke:objc-test-filter
Jul 20, 2021
Merged

fluttergithubbot merged 1 commit into
flutter-team-archive:masterfrom
gaaclarke:objc-test-filter

Conversation

@gaaclarke

Copy link
Copy Markdown
Contributor

Other unit tests had this feature, now we have it for objc too.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke
gaaclarke requested a review from dnfield July 19, 2021 23:15
@google-cla google-cla Bot added the cla: yes label Jul 19, 2021
@gaaclarke gaaclarke mentioned this pull request Jul 19, 2021
9 tasks done

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 19, 2021
@fluttergithubbot
fluttergithubbot merged commit b477645 into flutter-team-archive:master Jul 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2021
zanderso pushed a commit to flutter/flutter that referenced this pull request Jul 20, 2021
* dd48504 add test for scaled playback of DL and SkPicture (flutter-team-archive/engine#27503)

* 791e2dc Roll Fuchsia Linux SDK from FGuPZEZLt... to 665qcW5C1... (flutter-team-archive/engine#27561)

* dd95642 Roll Skia from fe49b2c6f41b to 946a4cb8acb7 (9 revisions) (flutter-team-archive/engine#27564)

* b477645 Added a test filter for objc tests (flutter-team-archive/engine#27566)

* 6975e55 Roll Fuchsia Mac SDK from 897eI2xwc... to rQOi2N8BM... (flutter-team-archive/engine#27572)

* a0f41b2 Roll Skia from 946a4cb8acb7 to 38a6e5aa1a49 (8 revisions) (flutter-team-archive/engine#27573)

* 024dbab Roll Skia from 38a6e5aa1a49 to 2373b9ed9617 (1 revision) (flutter-team-archive/engine#27574)

* 1898563 Roll Skia from 2373b9ed9617 to 3f6e8d8864bb (2 revisions) (flutter-team-archive/engine#27575)

* ef9ac75 Roll Skia from 3f6e8d8864bb to b5cd95b58fba (2 revisions) (flutter-team-archive/engine#27576)

* 1de3b87 MacOS: Release backbuffer surface when idle (flutter-team-archive/engine#27189)

* a1ed81a Roll Skia from b5cd95b58fba to d37bb6ae7248 (1 revision) (flutter-team-archive/engine#27578)

* 52b976c Extract the prebuilt Dart SDK to a temp directory and then move it after the extraction completes (flutter-team-archive/engine#27569)

* 00da6c3 Roll Fuchsia Linux SDK from 665qcW5C1... to q6H_ZE5Bs... (flutter-team-archive/engine#27581)

* 19f853d Roll Dart SDK from b410651bd18e to f82b36d0b4f0 (5 revisions) (flutter-team-archive/engine#27582)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Development

Successfully merging this pull request may close these issues.

3 participants