This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
add test for scaled playback of DL and SkPicture - #27503
Merged
fluttergithubbot merged 1 commit intoJul 20, 2021
Merged
fluttergithubbot merged 1 commit into
fluttergithubbot merged 1 commit into
Conversation
Contributor
Author
|
FYI, @untp |
gw280
approved these changes
Jul 19, 2021
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 20, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 20, 2021
* dd48504 add test for scaled playback of DL and SkPicture (flutter-team-archive/engine#27503) * 791e2dc Roll Fuchsia Linux SDK from FGuPZEZLt... to 665qcW5C1... (flutter-team-archive/engine#27561) * dd95642 Roll Skia from fe49b2c6f41b to 946a4cb8acb7 (9 revisions) (flutter-team-archive/engine#27564) * b477645 Added a test filter for objc tests (flutter-team-archive/engine#27566) * 6975e55 Roll Fuchsia Mac SDK from 897eI2xwc... to rQOi2N8BM... (flutter-team-archive/engine#27572) * a0f41b2 Roll Skia from 946a4cb8acb7 to 38a6e5aa1a49 (8 revisions) (flutter-team-archive/engine#27573) * 024dbab Roll Skia from 38a6e5aa1a49 to 2373b9ed9617 (1 revision) (flutter-team-archive/engine#27574) * 1898563 Roll Skia from 2373b9ed9617 to 3f6e8d8864bb (2 revisions) (flutter-team-archive/engine#27575) * ef9ac75 Roll Skia from 3f6e8d8864bb to b5cd95b58fba (2 revisions) (flutter-team-archive/engine#27576) * 1de3b87 MacOS: Release backbuffer surface when idle (flutter-team-archive/engine#27189) * a1ed81a Roll Skia from b5cd95b58fba to d37bb6ae7248 (1 revision) (flutter-team-archive/engine#27578) * 52b976c Extract the prebuilt Dart SDK to a temp directory and then move it after the extraction completes (flutter-team-archive/engine#27569) * 00da6c3 Roll Fuchsia Linux SDK from 665qcW5C1... to q6H_ZE5Bs... (flutter-team-archive/engine#27581) * 19f853d Roll Dart SDK from b410651bd18e to f82b36d0b4f0 (5 revisions) (flutter-team-archive/engine#27582)
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test should verify the condition that we were seeing when upstream golden tests were running on the "DL enabled by default" patch.
Basically, when we play back shadows under a new transform (i.e. scale) the shadows looked different because they were half processed under one transform and half under another. This was actually a bug in the way we were handling shadows that was fixed by another PR (#27124) in the meantime so now our shadows show up just fine whether we record them in the final CTM or under some other CTM.
There is no fix here, just a new early-catch test to make sure that we continue to meet these conditions that will be expected down the road when further tests are run and that DL behaves under those conditions identically to the way that SkPicture used to behave (where "used to behave" means "since 27124 was fixed but before DL is enabled").
The timeline is along the lines of:
(These tests don't really test 27124 so much as they test the compatibility between the way that DL and SkP record shadows under the new shadow implementation)