Migrate out_copy and out_roundrobin to v0.14 API #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests of this change will fail because ArrayEventStream does NOT dup records correctly (and it's not tested in old test code). |
|
After merged this and #1066, we should release v0.14.1 soon. |
| @weights = [] | ||
| end | ||
|
|
||
| attr_reader :outputs, :weights | ||
| attr_reader :weights | ||
| attr_accessor :rand_seed |
There was a problem hiding this comment.
Can we remove this accessor?
There was a problem hiding this comment.
Maybe yes. I have no idea about it.
|
LGTM with removing unnecessary |
|
I pushed a comment to remove |
tagomoris
force-pushed
the
migrate-plugin-v14-copy-rr
branch
from
b081575
to
4a2b7b3
Compare
|
Rebased on #1063 changes due to fixes on |
tagomoris
force-pushed
the
migrate-plugin-v14-copy-rr
branch
from
4a2b7b3
to
00a7e1b
Compare
tagomoris
force-pushed
the
migrate-plugin-v14-copy-rr
branch
from
00a7e1b
to
346dc73
Compare
|
I've rebased on current master HEAD. I'll merge this change after CI green. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #1040 too.