Plugin helper tag time hostname #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagomoris
force-pushed
the
plugin-helper-tag-time-hostname
branch
from
f0cd866
to
944cfe6
Compare
…ug not to dup correctly
tagomoris
force-pushed
the
plugin-helper-tag-time-hostname
branch
from
944cfe6
to
46ebbd3
Compare
|
@repeatedly This change is required for v0.14.1 because this change introduces a plugin helper instead of deprecated SetTimeKeyMixin/SetTagKeyMixin, and changes how to write plugins. |
|
Okay, let me check. Please wait. |
| module Fluent | ||
| module PluginHelper | ||
| module Inject | ||
| def inject_record(tag, time, record) |
There was a problem hiding this comment.
inject_record is misleading name.
inject is used like inject xxx into yyy so this name seems to mean inject record into yyy.
So we should use other name, inject_value_to_record, mutate_record or something.
There was a problem hiding this comment.
Plugin Helper methods should be named as ${helper_name}_anything.
So I'll change these names as inject_values_to_record and inject_values_to_event_stream.
|
I pushed some commits to fix (mainly) tests. |
…to x86/amd64 floating points. Using fixed value (calculated in amd64 environment) is unsafe, because some x86 environment (like Windows 32bit) uses different way to calculate floating point values. It may cause to make tests to fail.
|
Now CI is green, finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin helper is to inject tag, time and hostname into records.
This plugin helper will replace SetTagKeyMixin/SetTimeKeyMixin, by explicit method calls instead of overridden
filter_record.hostname_keyis also added to solve feature requests to inject it into a field.