msi: Disable auto start after install #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many users would be happier if it didn't start automatically: * No one would be happy to start Fluentd with the default settings. * It opens some ports by default. It is undesirable from a security point of view. In addition, we should make sure that the service starts after all install actions are completed. To achieve it, this is preferable for now. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
We actually need this for |
ashie
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
It'll be nice that the installer's exit dialog notice the user needs to start the service manually.
https://wixtoolset.org/docs/v3/wixui/wixui_customizations/#customizing-the-exitdlg
I don't require it in this PR though.
|
Thanks for your review! |
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users would be happier if it didn't start automatically:
In addition, we should make sure that the service starts after all install actions are completed.
To achieve it, this is preferable for now.