-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msi: migration to c:\opt\fluent #494
Conversation
7ec01d6
to
9a06366
Compare
InstallExecuteSequence doesn't work as expected 🤔 |
newly install works as expected, not for upgrade. |
|
PostInstall action is called.
|
postinstall's |
check error log: |
Should align not expected WixQuietExec64 execution order. |
upgrade-echo-on.u8.log |
It is out of scope, I've found that post-install was always called because of a mismatch...
|
When executing extracted bat file content to simplified msi, it will be kicked. (even though weird mojibake errror) |
d5882e4
to
7fb0059
Compare
with 7fb0059, WixQuietExec64 failure was fixed, but it works still unexpectdly, checking why... |
Thanks! I will review this again! |
86abff1
to
779e0d0
Compare
Before: * Configuration c:\opt\td-agent\etc\td-agent\td-agent.conf * Log files: c:\opt\td-agent After: * Move configuration to c:\opt\fluent\etc\fluent\td-agent.conf * Create symbolic link to c:\opt\fluent\etc\fluent as c:\opt\fluent\var\log\fluent. * Overwrite c:\opt\fluent\etc\fluentd.conf with td-agent.conf (when upgrade) * Migrate to FLUENT_PACKAGE_TOPDIR environment variable. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
See fluent/fluentd#1138 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
After: * Move configuration files to c:\opt\fluent\etc\fluent\td-agent.conf * Create symbolic link to c:\opt\fluent\etc\fluent. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
I have rebased this to apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the migration process works stably!
I have several concerns on a point other than the migration process itself.
I have commented them below.
evaluation should be delayed until executing fluentd. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Install test seems failed since ab9df59
|
Remove needless FLUENT_PACKAGE_TOPDIR=. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Redundant expression causes registration error. |
Thanks! I will check the behavior of the package after CI finishes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should handle the following points in other PRs.
ENV['FLUENT_PACKAGE_TOPDIR']
andENV['TD_AGENT_TOPDIR']
: msi: migration to c:\opt\fluent #494 (comment)- Rollback: msi: migration to c:\opt\fluent #494 (comment)
msi: migrate to c:\opt\fluent
Before:
After: