msi: migration to c:\opt\fluent #494

kenhys · 2023-06-08T09:08:12Z

msi: migrate to c:\opt\fluent

Before:

Configuration c:\opt\td-agent\etc\td-agent\td-agent.conf
Log files: c:\opt\td-agent

After:

Move configuration to c:\opt\fluent\etc\fluent\td-agent.conf
Create symbolic link to c:\opt\fluent\etc\fluent from c:\opt\td-agent\etc\td-agent.
Overwrite c:\opt\fluent\etc\fluentd.conf with td-agent.conf (when upgrade)
Migrate to FLUENT_PACKAGE_TOPDIR environment variable.
Keep old logs as is:

kenhys · 2023-06-19T07:29:47Z

debug-msi.log

InstallExecuteSequence doesn't work as expected 🤔

kenhys · 2023-06-19T08:02:09Z

newly install works as expected, not for upgrade.
pr494-new-install.log
pr494-upgrade.log

kenhys · 2023-06-19T08:14:35Z

~~Unexpectedly action was skipped~~ this action should not executed during upgrade.

MSI (s) (50:1C) [16:52:42:112]: Note: 1: 2265 2:  3: -2147287035 
MSI (s) (50:1C) [16:52:42:112]: Server not locked: locking for product {4FEF158E-E67C-4D05-B7E2-55DA1B33AF9F}
Action ended 16:52:42: InstallInitialize. Return value 1.
MSI (s) (50:1C) [16:52:42:125]: Skipping action: SetDeleteCompatTdAgentBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Skipping action: DeleteCompatTdAgentBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Skipping action: SetDeleteCompatTdAgentGemBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Skipping action: DeleteCompatTdAgentGemBat (condition is false)
MSI (s) (50:1C) [16:52:42:125]: Doing action: ProcessComponents
MSI (s) (50:1C) [16:52:42:125]: Note: 1: 2205 2:  3: ActionText 
Action 16:52:42: ProcessComponents. Updating component registration
Action start 16:52:42: ProcessComponents.

kenhys · 2023-06-19T08:27:31Z

PostInstall action is called.

MSI (s) (50:1C) [16:53:06:342]: Executing op: ActionStart(Name=PostInstall,,)
Action 16:53:06: PostInstall. 
MSI (s) (50:1C) [16:53:06:344]: Executing op: CustomActionSchedule(Action=PostInstall,ActionType=3073,Source=BinaryData,Target=WixQuietExec64,CustomActionData="c:\opt\fluent\bin\fluent-package-post-install.bat")
MSI (s) (50:B4) [16:53:06:352]: Invoking remote custom action. DLL: C:\WINDOWS\Installer\MSICEAC.tmp, Entrypoint: WixQuietExec64
WixQuietExec64:  Restoring gems to pristine condition...
WixQuietExec64:  Skipped error_highlight-0.5.1, it is a default gem

kenhys · 2023-06-19T08:38:56Z

postinstall's if exist "%~dp0..\..\td-agent" ( condition may not be evaluated expectedly 🤔

kenhys · 2023-06-20T05:12:14Z

check error log:
upgrade.take1.rollback.zip

kenhys · 2023-06-20T05:48:50Z

check error log: upgrade.take1.rollback.zip

Should align not expected WixQuietExec64 execution order.

kenhys · 2023-06-21T08:41:33Z

upgrade-echo-on.u8.log
tracked via @echo on, but it seems that the second if exist ... sequence is not executed.

kenhys · 2023-06-22T05:30:22Z

It is out of scope, I've found that post-install was always called because of a mismatch...

WixQuietExec64:  C:\Windows\SysWOW64>if not "c:\opt\fluent\bin\" == "C:\opt\fluent\bin\" ("c:\opt\fluent\bin\gem" pristine --only-executables --all ) 
WixQuietExec64:  Restoring gems to pristine condition...

kenhys · 2023-06-22T07:50:22Z

When executing extracted bat file content to simplified msi, it will be kicked. (even though weird mojibake errror)

kenhys · 2023-06-23T07:47:10Z

with 7fb0059, WixQuietExec64 failure was fixed, but it works still unexpectdly, checking why...

kenhys · 2023-06-23T08:57:23Z

c:\opt\td-agent was linked to c:\opt\fluent.

kenhys · 2023-06-23T08:58:26Z

c:\opt\fluent\var\log\td-agent was linked to c:\opt\fluent\var\log\fluent.

kenhys · 2023-07-04T05:27:11Z

daipom · 2023-07-06T03:11:08Z

Thanks! I will review this again!

fluent-package/msi/assets/fluent-package-post-migration.bat

Before: * Configuration c:\opt\td-agent\etc\td-agent\td-agent.conf * Log files: c:\opt\td-agent After: * Move configuration to c:\opt\fluent\etc\fluent\td-agent.conf * Create symbolic link to c:\opt\fluent\etc\fluent as c:\opt\fluent\var\log\fluent. * Overwrite c:\opt\fluent\etc\fluentd.conf with td-agent.conf (when upgrade) * Migrate to FLUENT_PACKAGE_TOPDIR environment variable. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

See fluent/fluentd#1138 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

After: * Move configuration files to c:\opt\fluent\etc\fluent\td-agent.conf * Create symbolic link to c:\opt\fluent\etc\fluent. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

daipom · 2023-07-10T08:49:45Z

I have rebased this to apply

msi: Disable auto start after install #521

daipom

Now the migration process works stably!

I have several concerns on a point other than the migration process itself.
I have commented them below.

fluent-package/msi/assets/fluent-package-post-migration.bat

fluent-package/msi/assets/fluentd.bat

fluent-package/msi/assets/fluent-package-post-migration.bat

evaluation should be delayed until executing fluentd. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

ashie · 2023-07-11T08:08:12Z

Install test seems failed since ab9df59

Installing C:\fluentd\fluent-package\msi\repositories\fluent-package-5.0.0-x64.msi 
Start-Service : Cannot find any service with service name 'fluentdwinsvc'. 
At C:\fluentd\fluent-package\msi\install-test.ps1:7 char:1
+ Start-Service fluentdwinsvc
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (fluentdwinsvc:String) [Start-Se  
   rvice], ServiceCommandException
    + FullyQualifiedErrorId : NoServiceFoundForGivenName,Microsoft.PowerShell.  
   Commands.StartServiceCommand

Remove needless FLUENT_PACKAGE_TOPDIR=. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

kenhys · 2023-07-12T01:57:30Z

Redundant expression causes registration error.
It will be fixed via 40bc79d.

daipom · 2023-07-12T02:07:00Z

Thanks! I will check the behavior of the package after CI finishes.

daipom

LGTM.

We should handle the following points in other PRs.

ENV['FLUENT_PACKAGE_TOPDIR'] and ENV['TD_AGENT_TOPDIR']: msi: migration to c:\opt\fluent #494 (comment)
Rollback: msi: migration to c:\opt\fluent #494 (comment)

kenhys changed the title ~~msi: migration to c:\opt\fluent~~ Draft msi: migration to c:\opt\fluent Jun 8, 2023

kenhys force-pushed the win-migration branch 6 times, most recently from 7ec01d6 to 9a06366 Compare June 19, 2023 07:28

kenhys force-pushed the win-migration branch from 5d36e97 to 805cef6 Compare June 19, 2023 08:33

kenhys force-pushed the win-migration branch from 805cef6 to 57e03de Compare June 19, 2023 08:42

kenhys force-pushed the win-migration branch from 4921c94 to 6fcce12 Compare June 20, 2023 05:43

kenhys force-pushed the win-migration branch from 6fcce12 to c7272e8 Compare June 22, 2023 04:27

kenhys force-pushed the win-migration branch 5 times, most recently from d5882e4 to 7fb0059 Compare June 23, 2023 06:35

kenhys force-pushed the win-migration branch from 7fb0059 to ecb63fd Compare June 23, 2023 08:22

kenhys marked this pull request as ready for review July 4, 2023 05:30

kenhys force-pushed the win-migration branch from 5d15322 to f285807 Compare July 5, 2023 01:23

daipom reviewed Jul 7, 2023

View reviewed changes

fluent-package/msi/assets/fluent-package-post-migration.bat Outdated Show resolved Hide resolved

kenhys mentioned this pull request Jul 10, 2023

Migrate TD_AGENT_ prefix to FLUENT_PACKAGE_ #517

Merged

daipom force-pushed the win-migration branch from ae07175 to f285807 Compare July 10, 2023 03:07

daipom mentioned this pull request Jul 10, 2023

msi: Disable auto start after install #521

Merged

daipom force-pushed the win-migration branch 2 times, most recently from 86abff1 to 779e0d0 Compare July 10, 2023 07:57

kenhys and others added 6 commits July 10, 2023 17:47

msi: fix title

409a1c9

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

msi test: follow changed path

968dc7a

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

msi: use / as path separator

c25fbc8

See fluent/fluentd#1138 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

msi: add migration batch sequence

d459fc6

After: * Move configuration files to c:\opt\fluent\etc\fluent\td-agent.conf * Create symbolic link to c:\opt\fluent\etc\fluent. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>

msi: migrate to FLUENT_PACKAGE_TOPDIR

e6ff86f

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

daipom force-pushed the win-migration branch from 779e0d0 to e6ff86f Compare July 10, 2023 08:49

daipom reviewed Jul 10, 2023

View reviewed changes

fluent-package/msi/assets/fluent-package-post-migration.bat Outdated Show resolved Hide resolved

fluent-package/msi/assets/fluentd.bat Outdated Show resolved Hide resolved

daipom reviewed Jul 11, 2023

View reviewed changes

fluent-package/msi/assets/fluent-package-post-migration.bat Show resolved Hide resolved

kenhys added 2 commits July 11, 2023 13:43

msi: expand scope of enabledelayedexpansion

ab9df59

evaluation should be delayed until executing fluentd. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

msi: add /F for debugging

7dd63bb

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

msi: fix path replacement

40bc79d

Remove needless FLUENT_PACKAGE_TOPDIR=. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

daipom approved these changes Jul 14, 2023

View reviewed changes

daipom merged commit c974a20 into fluent:master Jul 14, 2023
18 of 19 checks passed

kenhys deleted the win-migration branch July 20, 2023 05:29

daipom mentioned this pull request Nov 28, 2023

Add option to choice whether it enables to start fluentd service or not #601

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

msi: migration to c:\opt\fluent #494

msi: migration to c:\opt\fluent #494

kenhys commented Jun 8, 2023 •

edited

Loading

kenhys commented Jun 19, 2023

kenhys commented Jun 19, 2023

kenhys commented Jun 19, 2023 •

edited

Loading

kenhys commented Jun 19, 2023

kenhys commented Jun 19, 2023

kenhys commented Jun 20, 2023

kenhys commented Jun 20, 2023

kenhys commented Jun 21, 2023

kenhys commented Jun 22, 2023

kenhys commented Jun 22, 2023

kenhys commented Jun 23, 2023

kenhys commented Jun 23, 2023

kenhys commented Jun 23, 2023

kenhys commented Jul 4, 2023

daipom commented Jul 6, 2023

daipom commented Jul 10, 2023

daipom left a comment •

edited

Loading

ashie commented Jul 11, 2023

kenhys commented Jul 12, 2023

daipom commented Jul 12, 2023

daipom left a comment •

edited

Loading

msi: migration to c:\opt\fluent #494

msi: migration to c:\opt\fluent #494

Conversation

kenhys commented Jun 8, 2023 • edited Loading

kenhys commented Jun 19, 2023

kenhys commented Jun 19, 2023

kenhys commented Jun 19, 2023 • edited Loading

kenhys commented Jun 19, 2023

kenhys commented Jun 19, 2023

kenhys commented Jun 20, 2023

kenhys commented Jun 20, 2023

kenhys commented Jun 21, 2023

kenhys commented Jun 22, 2023

kenhys commented Jun 22, 2023

kenhys commented Jun 23, 2023

kenhys commented Jun 23, 2023

kenhys commented Jun 23, 2023

kenhys commented Jul 4, 2023

daipom commented Jul 6, 2023

daipom commented Jul 10, 2023

daipom left a comment • edited Loading

Choose a reason for hiding this comment

ashie commented Jul 11, 2023

kenhys commented Jul 12, 2023

daipom commented Jul 12, 2023

daipom left a comment • edited Loading

Choose a reason for hiding this comment

kenhys commented Jun 8, 2023 •

edited

Loading

kenhys commented Jun 19, 2023 •

edited

Loading

daipom left a comment •

edited

Loading

daipom left a comment •

edited

Loading