Skip to content

Conversation

@Jakob3xD
Copy link
Contributor

What this PR does / why we need it:

The current v3.4.0 release is not usable via HELM as the versions of the charts were not adjusted.
To prevent this in the future, I adjusted the release documentation.
For each release the version and appVersions should also be bumped.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
@marcofranssen
Copy link
Collaborator

According to the current release process those are bumped here

https://github.com/fluent/fluent-operator/tree/release-3.4

@Jakob3xD
Copy link
Contributor Author

@marcofranssen
As I already explain in #1620 (comment) the current release process is incorrectly documented and therefore the current release is broken and unusable to deploy via Helm.

I am quite upset that you closed both PRs without commenting a detailed reason, even tough I am telling you that the current release is BROKEN.

@joshuabaird
Copy link
Collaborator

@Jakob3xD I believe the 3.4.0 release was based off of the release-3.4 branch which does have the correct version and appVersion -- with the exception of the sub CRD charts which we need to look at.

The v3.4.0 chart (and app) will be available via Helm once this PR is merged.

I am however in agreement that our release process is currently not ideal and we need to improve it. I'm going to try and get a maintainer+community meeting scheduled soon so that we can talk about this.

@Jakob3xD
Copy link
Contributor Author

Jakob3xD commented May 20, 2025

@joshuabaird thanks you for the comment.
The branch release-3.4 has the correct appVersion but the version is currently set to 3.3.0 and needs to be bumped to 3.4.0 as with every change made to the chart the version needs to be increased.

The referenced PR won't work in it current state as the version of both CRD chars need to be bumped. This is also commented above the version in the Chart.yaml

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.

Helm does not apply the changes if the version stays the same.

My goal with the PR was to reflect the actual release process like it was done in the previous releases.

However as the release process states that the helm repo content should be copied from this repo, I opened another PR to fix this #1620 which got also closed.
As written in the PR, if force pushing the tag with the correct chart version is not suitable, a patch release is needed to resolve this.

@joshuabaird
Copy link
Collaborator

You're right -- I missed that version is still 3.3.0 on the release-3.4 branch.

@Jakob3xD
Copy link
Contributor Author

I adjusted my comment. I meant #1620 which targets the release-3.4 branch.

This was referenced May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants