bug: Faulty v3.4.0 Release

[Jakob3xD]

Describe the issue

The v3.4.0 release did not update the helm charts, resulting in flux not updating the HELM chart.
https://fluxcd.io/flux/components/source/helmcharts/#reconcile-strategy

When doing a release, all the HELM charts need to be updated if they got changed, including the version, appVersion and the version of the dependencies. Like it is done in the v3.3.0 tag. This is also commented to the chart files itself.

fluent-operator/charts/fluent-operator/charts/fluentd-crds/Chart.yaml

Lines 14 to 23 in ef3ec94

	# This is the chart version. This version number should be incremented each time you make changes
	# to the chart and its templates, including the app version.
	# Versions are expected to follow Semantic Versioning (https://semver.org/)
	version: 3.3.0
	# This is the version number of the application being deployed. This version number should be
	# incremented each time you make changes to the application. Versions are not expected to
	# follow Semantic Versioning. They should reflect the version the application is using.
	# It is recommended to use it with quotes.
	appVersion: "3.3.0"

fluent-operator/charts/fluent-operator/charts/fluent-bit-crds/Chart.yaml

Lines 14 to 23 in ef3ec94

	# This is the chart version. This version number should be incremented each time you make changes
	# to the chart and its templates, including the app version.
	# Versions are expected to follow Semantic Versioning (https://semver.org/)
	version: 3.3.0
	# This is the version number of the application being deployed. This version number should be
	# incremented each time you make changes to the application. Versions are not expected to
	# follow Semantic Versioning. They should reflect the version the application is using.
	# It is recommended to use it with quotes.
	appVersion: "3.3.0"

fluent-operator/charts/fluent-operator/Chart.yaml

Lines 9 to 26 in ef3ec94

	version: 3.3.0
	appVersion: 3.3.0
	icon: https://raw.githubusercontent.com/fluent/fluent-operator/master/docs/images/fluent-operator-icon.svg
	home: https://www.fluentd.org/
	sources:
	- https://github.com/fluent/fluent-operator
	maintainers:
	- name: wenchajun
	email: dehaocheng@kubesphere.io
	dependencies:
	- name: fluent-bit-crds
	repository: "file://charts/fluent-bit-crds"
	version: 3.3.0
	condition: fluentbit.crdsEnable
	- name: fluentd-crds
	repository: "file://charts/fluentd-crds"
	version: 3.3.0
	condition: fluentd.crdsEnable

To Reproduce

Use flux inside a k8s cluster and try to use the chart from this repo.

Expected behavior

1. Adjust the RELEASE.md, so when performing a release, all the chart version values get bumped.
   One could argue that when nothing got changes for the CRD's a version change is not needed. Which is correct, but the versions of all the three charge would differ.
   My suggestion to this is Adjust RELEASE.md to also bump the helm chart for a release #1619

2. Fix the v3.4.0 release by updating the mention values above and force pushing the tag or performing a patch release for fixing the chart versions.
   My suggestion to this is charts: fix chart version and appVersion #1620

Your Environment

- Fluent Operator version:
- Container Runtime:
- Operating system:
- Kernel version:

How did you install fluent operator?

No response

Additional context

No response

[Jakob3xD]

@marcofranssen @joshuabaird

To give the issue a better platform to discuss instead of different PRs, I opened this issue. If you have any questions or disagree with any of it, I'll ne happy to explain.

In addition, I want to apologize for my language in the comments of both PRs. I was just quite upset that even tough I report the issue via the PRs and also tried solving them, they both got closed without discussing.

[cw-Guo]

it's an awkward situation that we are actually in a middle of release-3.4. The active maintainers lack the permissions to the helm chart repo, which blocks the merge of this pr fluent/helm-charts#602

[marcofranssen]

@Jakob3xD Please also note the release of the operator is having a different lifecycle then the release of the chart, similar like fluent-bit has a different release cycle.

Note the release of the chart was done 13 hours ago, so you should have the fix there by now.

[Jakob3xD]

Please also note the release of the operator is having a different lifecycle then the release of the chart, similar like fluent-bit has a different release cycle.

Note the release of the chart was done 13 hours ago, so you should have the fix there by now.

That is false and what I am trying to tell you.

You release the helm chart in the helm repo separately, but the content is coming from this repo. More over, you only release a new chart only when the Operator version changed. Therefore, they have a different lifecycle but are coupled. So the chart depends on the release of the operator.

When you did the release, you followed the RELASE.md as it is written, but this is the reason why it is broken or at least can cause broken releases.

If you don't bump the version and appVersion of all three charts in this repo during the release you tend to forget updating those, because the documented steps for updating the chart in RELASE.md is missing the part where you should update the version and appVersion of both CRD charts.

Yes, you update the version and appVersion of the fluent-operator main chart, but you did NOT update those for the fluent-bit-crds and fluentd-crds chart. As you can see in your own PR fluent/helm-charts#602, you changed the CRD's in both charts and therefore the version needs to be bumped. This is not optional.

That is why the release is broken.

Can you follow me of what I am trying to tell you and what my issue is?

[joshuabaird]

Yes - the CRD charts need to be bumped in addition to the fluent-operator chart.

[PRYeswanthReddy]

i dont see the tgz file for fluent-operator, which is used to install crds can you publish that for 3.4.0?

wget https://github.com/fluent/fluent-operator/releases/download//fluent-operator.tgz
tar -xf fluent-operator.tgz
kubectl replace -f fluent-operator/crds

[marcofranssen]

i dont see the tgz file for fluent-operator, which is used to install crds can you publish that for 3.4.0?

wget https://github.com/fluent/fluent-operator/releases/download//fluent-operator.tgz tar -xf fluent-operator.tgz kubectl replace -f fluent-operator/crds

Done 👍

[Jakob3xD]

Are you planing on changing the RELEASE.md to prevent this in the future, and is there going to be a 3.4.1 tag/release?

[marcofranssen]

@Jakob3xD yes we will need to revamp the release process. And yes we should cut a new release.