Addressing issue 145 #160
Merged
Addressing issue 145 #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjang96
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
|
@kjang96 can u resolve the pep8 conflicts? |
|
Did you add the required params to the rllib examples as well? |
|
@kjang96 I think all of the grid experiments everywhere will fail unless you add these params to their additional_env_params now |
…re_eight scenarios
crystalzyan
pushed a commit
to crystalzyan/flow
that referenced
this pull request
Dec 1, 2018
* Addressing issue 145 * Fixed setup script env_params to reflect new changes * Fixed pep8 issues * Added new green_wave_env requirements to rllib/green_wave.py * Added new env params to the benchmark experiments as well * Added env params to baseline as well. nose2 not passing for some figure_eight scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145. Added checks to the
__init__for both classes in thegreen_wave_envfile. Edited the experiment runner code ingreen_wave.pyto express these changes