Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter#get_all #255

Merged
merged 13 commits into from
May 10, 2017
Merged

Adapter#get_all #255

merged 13 commits into from
May 10, 2017

Commits on May 8, 2017

  1. Add preload_all

    @jnunemaker
    jnunemaker committed May 8, 2017
    Configuration menu
    Copy the full SHA
    d11e0d8 View commit details
    Browse the repository at this point in the history

  2. Use preload_all in memoizer middleware

    @jnunemaker
    jnunemaker committed May 8, 2017
    Configuration menu
    Copy the full SHA
    38b37c0 View commit details
    Browse the repository at this point in the history

  3. Minor formatting change

    @jnunemaker
    jnunemaker committed May 8, 2017
    Configuration menu
    Copy the full SHA
    50bbcf6 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2017

  1. Add pry for debugging

    @jnunemaker
    jnunemaker committed May 9, 2017
    Configuration menu
    Copy the full SHA
    a148d55 View commit details
    Browse the repository at this point in the history

  2. Add default get_all implementation for adapters

    @jnunemaker
    jnunemaker committed May 9, 2017
    Configuration menu
    Copy the full SHA
    403d7d2 View commit details
    Browse the repository at this point in the history

  3. Use get_all in preload_all

    @jnunemaker
    jnunemaker committed May 9, 2017
    Configuration menu
    Copy the full SHA
    ce5599e View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Allow conditionally memoizing with the middleware 

    Sometimes assets or other things get served by rails which means this
middleware is invoked. Having unless makes it easy to skip those.
    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    2f47aeb View commit details
    Browse the repository at this point in the history

  2. Remove one hash key read

    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    65ef697 View commit details
    Browse the repository at this point in the history

  3. Add efficient get_all to http adapter 

    This reduces the number of http requests for preload_all to one from
two. Twice as nice...
    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    3d0dd3d View commit details
    Browse the repository at this point in the history

  4. Add docs for memoizer middleware unless option

    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    ce040ee View commit details
    Browse the repository at this point in the history

  5. Add docs for default Adapter#get_all

    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    1250970 View commit details
    Browse the repository at this point in the history

  6. Make rubocop happy

    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    e3e69df View commit details
    Browse the repository at this point in the history

  7. Update docs to use start with

    @jnunemaker
    jnunemaker committed May 10, 2017
    Configuration menu
    Copy the full SHA
    648a5e4 View commit details
    Browse the repository at this point in the history