Adapter#get_all #255
Merged
Adapter#get_all #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes assets or other things get served by rails which means this middleware is invoked. Having unless makes it easy to skip those.
This reduces the number of http requests for preload_all to one from two. Twice as nice...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously preload_all made to adapter calls -- features and get_multi with result of features. This makes it so an adapter can get all features and gate values in one call instead of two by adding
Adapter#get_all. The default implementation is a call to features and then to get_multi like before, but now it is possible for adapters to be more efficient and do it all in one call. I added it to Http adapter as an example. I'll open an issue to add it to other adapters.