Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation for page.on_resize #3516

Closed
1 task done
InesaFitsner opened this issue Jun 21, 2024 · 0 comments · Fixed by #3507
Closed
1 task done

Remove deprecation for page.on_resize #3516

InesaFitsner opened this issue Jun 21, 2024 · 0 comments · Fixed by #3507
Assignees
@ndonkoHenri
Labels
enhancement Improvement/Optimization

Comments

@InesaFitsner
Copy link
Contributor

Duplicate Check

Describe the bug

page.window.on_resized doesn't work for web and mobile so we need to remove deprecation for page.on_resize

Code

import flet as ft

def main(page: ft.Page):

    def page_resize(e):
        print("Page resize triggered")

    page.on_resize = page_resize

ft.app(main)

To reproduce

  1. Run repro code -> page_resize is not triggered

Expected behavior

No response

Screenshots

No response

Operating System

macOS

Operating system details

macOS

Flet version

0.23.0

Regression

Yes, it used to work in a previous Flet version (please specify the version in additional details)

Suggestions

No response

Additional details

No response
@InesaFitsner InesaFitsner added the bug: regression A feature that worked correctly doesn't anymore label Jun 21, 2024
ndonkoHenri added a commit that referenced this issue Jun 22, 2024
@ndonkoHenri
Fix #3516: delete Page.window.on_resize | deprecate Page.on_resize in…
2038493 
… favor of Page.on_resized
@ndonkoHenri ndonkoHenri added enhancement Improvement/Optimization and removed bug: regression A feature that worked correctly doesn't anymore labels Jun 22, 2024
@ndonkoHenri ndonkoHenri linked a pull request Jun 22, 2024 that will close this issue
Flet v0.23 Post Fixes - Part 2 #3507
Merged
zrr1999 pushed a commit to zrr1999/flet that referenced this issue Jul 17, 2024
@ndonkoHenri @zrr1999
Flet v0.23 Post Fixes - Part 2 (flet-dev#3507)
31acc9b 
* Fix flet-dev#3503: `Slider.value` defaults to `min`

* Fix flet-dev#3505: add "hide" and "show" to  WindowEventType enum

* Fix flet-dev#3499: TypeError raised for isinstance check with Union in before_update method

- Corrected isinstance check in SnackBar.before_update to use a tuple of types instead of Union, resolving TypeError: "Subscripted generics cannot be used with class and instance checks".

* Fix `Page.open()` breaking after multiple calls

* Fix flet-dev#3516: delete Page.window.on_resize | deprecate Page.on_resize in favor of Page.on_resized

* Page: Typo in on_resized setter decorator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndonkoHenri ndonkoHenri

Labels
enhancement Improvement/Optimization
Projects
Flet Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flet v0.23 Post Fixes - Part 2 flet-dev/flet
2 participants
@InesaFitsner @ndonkoHenri