Flet v0.23 Post Fixes - Part 2 #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request includes two main changes: updating the default value logic for the 'value' property in the slider component and adding new event types ('HIDE' and 'SHOW') to the 'WindowEventType' enum. The slider's 'value' property now defaults to 'self.min' or 0, ensuring it respects the minimum value set. The 'WindowEventType' enum has been extended to support additional window events, enhancing the event handling capabilities. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
This was
linked to
issues
Jun 21, 2024
…_update method - Corrected isinstance check in SnackBar.before_update to use a tuple of types instead of Union, resolving TypeError: "Subscripted generics cannot be used with class and instance checks".
Closed
1 task
1 task
1 task
FeodorFitsner
approved these changes
Jun 24, 2024
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* Fix flet-dev#3503: `Slider.value` defaults to `min` * Fix flet-dev#3505: add "hide" and "show" to WindowEventType enum * Fix flet-dev#3499: TypeError raised for isinstance check with Union in before_update method - Corrected isinstance check in SnackBar.before_update to use a tuple of types instead of Union, resolving TypeError: "Subscripted generics cannot be used with class and instance checks". * Fix `Page.open()` breaking after multiple calls * Fix flet-dev#3516: delete Page.window.on_resize | deprecate Page.on_resize in favor of Page.on_resized * Page: Typo in on_resized setter decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request addresses a bug fix for the slider component's default value handling and enhances the WindowEventType enumeration by adding 'hide' and 'show' event types.