Skip to content

Conversation

Neptunium1129
Copy link

  • Svelte5 only Rune mode
  • add : function ContentOutside open Mode > Maximum update depth exceeded problem
  • edit : function bind : mount is maybe bug? detail is Svelte5 migration #114
  • add : autofocus modal contents

Hi there 👋

Thank you so much for creating a PR. To streamline the process and make sure that your changes can get merged easily, please stick to the following structure. See #47 for an example of how to create an excellent PR description.

Background

Describe the context on how you use svelte-simple-modal. E.g., plain Svelte app, SvelteKit, Sapper, SSR, etc.

Currently Observed Behavior

  • detail is Svelte5 migration #114
  • Bug Fix: mount was causing component duplication when repeatedly clicked.
  • mount was causing potential duplication issues when repeatedly clicking the button

New Behavior

  • Add: ContentOutside open mode - Prevents excessive updates, which were leading to a "Maximum update depth exceeded" error.
  • Add: Autofocus support for modal content - Ensures that modal elements receive focus when opened.

- Svelte5 only Rune mode
- add : function ContentOutside open Mode > Maximum update depth exceeded problem
- edit : function bind : mount is maybe bug? detail is flekschas#114
- add : autofocus modal contents
For Test
@Neptunium1129
Copy link
Author

plz check this pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant