I am using Svelte Simple Modal in Svelte 5 with some custom modifications. Would it be okay to submit a pull request?

[Neptunium1129]

I think Svelte Simple Modal is very useful, more so than other open-source modal options.

previous project used only Simple Modal.

[flekschas]

Totally! The only thing I hope we can achieve is backwards compatability with Svelte v4. If that's impossible we need to release a new major version of svelte-simple-modal.

[Neptunium1129]

Totally! The only thing I hope we can achieve is backwards compatability with Svelte v4. If that's impossible we need to release a new major version of svelte-simple-modal.

It seems unlikely that backward compatibility will be possible due to the introduction of Svelte 5

[flekschas]

Do you know what technically prevents that? When Svelte v4 was released, svelte-simple-modal continued to work just fine with Svelte v3.

[nltesown]

@Neptunium1129 I've taken a look at your fork https://github.com/Neptunium1129/svelte-simple-modal but I don't see any edit... svelte-simple-modal is a fantastic package and it definitely should be made compatible with Svelte 5. I wondered where would the incompatibility come from.

[flekschas]

@nltesown You could check #113 and #114. I'm happy to get a PR in for v5 support, I just don't have time to look into it myself right now. In the linked tickets, there was a backward-incompatible change I believe. If there's no way around it we can simply bump svelte simply modal to v2. That's totally fine

[Neptunium1129]

@Neptunium1129 I've taken a look at your fork https://github.com/Neptunium1129/svelte-simple-modal but I don't see any edit... svelte-simple-modal is a fantastic package and it definitely should be made compatible with Svelte 5. I wondered where would the incompatibility come from.

I have confirmed it works in my local environment and will update it soon.

[flekschas]

Svelte v5 support landed via #119. Checkout version 2.

[Neptunium1129]

Svelte v5 support landed via #119. Checkout version 2.

#121