Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: Hide ineffectual MFA checkbox on user form for team admins #24664

Merged

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Dec 11, 2024

For #24623, merged into main via #24656.

Also fixes some capitalization/pluralization issues for user management
for team admins

For #24623.

# Checklist for submitter
- [x] Manual QA for all new/changed functionality
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.61.0@470e07f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...serManagementPage/components/UserForm/UserForm.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.61.0   #24664   +/-   ##
=========================================================
  Coverage                          ?   63.53%           
=========================================================
  Files                             ?     1587           
  Lines                             ?   150528           
  Branches                          ?     3887           
=========================================================
  Hits                              ?    95631           
  Misses                            ?    47273           
  Partials                          ?     7624           
Flag Coverage Δ
frontend 53.67% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx iansltx merged commit c5fff77 into rc-minor-fleet-v4.61.0 Dec 11, 2024
11 checks passed
@iansltx iansltx deleted the cherry-pick-24623-mfa-team-admin-quick-cleanup branch December 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants