Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide ineffectual MFA checkbox on user form for team admins #24656

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Dec 11, 2024

Also fixes some capitalization/pluralization issues for user management for team admins

For #24623.

Checklist for submitter

  • Manual QA for all new/changed functionality

Also fixes some capitalization/pluralization issues for user management for team admins

For #24623.
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.56%. Comparing base (bf7876a) to head (5e7bf69).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...serManagementPage/components/UserForm/UserForm.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24656   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files        1600     1600           
  Lines      151545   151546    +1     
  Branches     3857     3858    +1     
=======================================
+ Hits        96336    96337    +1     
  Misses      47550    47550           
  Partials     7659     7659           
Flag Coverage Δ
frontend 53.91% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ian <3

@iansltx iansltx merged commit fda6bca into main Dec 11, 2024
14 checks passed
@iansltx iansltx deleted the 24623-mfa-team-admin-quick-cleanup branch December 11, 2024 19:07
iansltx added a commit that referenced this pull request Dec 11, 2024
Also fixes some capitalization/pluralization issues for user management
for team admins

For #24623.

# Checklist for submitter
- [x] Manual QA for all new/changed functionality
iansltx added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants