Skip to content

fix(permissions): honour permission on bulk actions and header items #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roncodes merged 1 commit into from
Sep 28, 2026
Merged

fix(permissions): honour permission on bulk actions and header items #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions addon/components/layout/header/smart-nav-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ export default class LayoutHeaderSmartNavMenuComponent extends Component {
// permission rather than being checked against its own (non-existent)
// extension ability, which would always throw and default to visible.
const abilityId = item._isShortcut && item._parentId ? item._parentId : item.id;
// Items (including shortcuts) may also declare their own permission,
// e.g. the module-level list permission for a shortcut.
if (item.permission && this.lacksPermission(item.permission)) {
continue;
}
try {
if (this.abilities.can(`${abilityId} see extension`)) {
visible.push(item);
Expand All @@ -192,6 +197,18 @@ export default class LayoutHeaderSmartNavMenuComponent extends Component {
return A(visible);
}

/**
* Whether the current user lacks the given permission. An undefined ability
* is treated as permitted, matching the extension check in `allItems`.
*/
lacksPermission(permission) {
try {
return this.abilities.cannot(permission);
} catch (_) {
return false;
}
}

/**
* Maximum number of items that may sit in the bar. Consumers can override
* via `@maxVisible={{n}}`.
Expand Down
13 changes: 13 additions & 0 deletions addon/components/layout/resource/tabular-actions.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,19 @@
{{#each @bulkActions as |bulkAction|}}
{{#if bulkAction.separator}}
<div class="next-dd-menu-seperator"></div>
{{else if (and bulkAction.permission (cannot bulkAction.permission))}}
{{! Same convention as action buttons: shown but disabled, with the unauthorized hint, and not clickable. }}
<div class="px-1">
<a href="javascript:;" class="next-dd-item {{bulkAction.class}} disabled" disabled={{true}} aria-disabled="true" {{on "click" (noop)}}>
{{#if bulkAction.icon}}
<div class="w-{{or bulkAction.iconWidth '6'}}"><FaIcon @icon={{bulkAction.icon}} @size={{or bulkAction.iconSize "sm"}} /></div>
{{/if}}
<div>{{or bulkAction.text bulkAction.label}}</div>
<Attach::Tooltip @class="clean" @animation="scale" @placement="right">
<InputInfo @text={{t "common.unauthorized"}} />
</Attach::Tooltip>
</a>
</div>
{{else}}
<div class="px-1">
<a href="#" class="next-dd-item {{bulkAction.class}}" {{on "click" (dropdown-fn dd bulkAction.fn)}}>
Expand Down