Repository navigation
fix(permissions): honour permission on bulk actions and header items - #185
Merged
Merged
Conversation
- Layout::Resource::Tabular bulk actions ignored bulkAction.permission, so users could run bulk delete/cancel/dispatch they were not allowed to. They now render disabled with the unauthorized hint, like action buttons. - The header smart nav hides items (including extension shortcuts) whose own permission the user lacks.
Merged
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layout::Resource::Tabularbulk actions ignoredbulkAction.permission, so a user could run bulk delete, cancel or dispatch without the permission. A bulk action whose permission fails now renders disabled, with the unauthorized hint and no click handler. This is the same convention the action buttons in the same template use.Layout::Header::SmartNavMenuhides items, including extension shortcuts, whose ownpermissionthe user lacks. It works together with fleetbase/ember-core, which copiespermissiononto registered shortcuts.Part of the Fleet-Ops permission enforcement audit (companion PRs in fleetops, core-api and ember-core).
Known gaps, not changed here
itemsinsideactionButtonsandpanel/header-actionsstill ignorepermission. Fleet-Ops filters its order details menu itself.Test plan
fleet-ops delete order: Orders → Bulk actions → Delete is disabled