Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some tests for the public behaviors of the
TabWidgetandTabWidgetTabBar.I did some reorganizing of the
TabWidgetclass to remove some logic that supported a commented-out feature, and to implement memoization for the displayed pane. I'm not sure if this would have performance implications due to eager rendering of some panes--so we might want to think about that a bit.I also just set the
currentTabIndexto be non-nullable with a default of 0, since the prior implementation appears to set it to 0 through a hook if it does happen to be undefined.