Test spa branch #92
Open
Test spa branch #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoules
commented
Jun 2, 2023
| sequenceUpdates = resp.sequences | ||
| } | ||
| if (sequenceUpdates) { | ||
| if (sequenceUpdates && sequenceUpdates.length > 0) { |
Collaborator
Author
There was a problem hiding this comment.
Turns out that an empty list ([]) is truthy.
| if (resp.type !== 'getProjectFile') { | ||
| console.warn(resp) | ||
| throw Error('Unexpected response from Stan Playground') | ||
| throw Error('Unexpected response from Stan Playground while retrieving project file') |
Collaborator
Author
There was a problem hiding this comment.
I made the error messages more specific to make it easier to distinguish the different test cases.
| expect(colorSets.length).toEqual(chains.length) | ||
| colorSets.forEach(cs => expect(chainColorsBase.includes(rgbToHex(cs))).toBeTruthy()) | ||
| }) | ||
| test("Renders black color swatch if appropriate color not found", () => { |
Collaborator
Author
There was a problem hiding this comment.
I'd missed this case earlier.
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 16.15% 18.55% +2.39%
==========================================
Files 80 80
Lines 5854 5854
Branches 138 161 +23
==========================================
+ Hits 946 1086 +140
+ Misses 4908 4768 -140
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I never actually hit the PR button on this--oops!
I think it's pretty straightforward--just adding some tests for the rest of the changes from the prior PR #85.