Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard on small mobile screens hiding composer #2631

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Feb 23, 2021

Fixes #2628

Reviewers should focus on:
You can test this by going to nightly and adding/removing this custom CSS

@media (max-width: 767px) {
  .Composer:not(.minimized) {
    height: 550px !important; /* This makes the composer long enough to emulate your mobile keyboard hiding a part of it (in case your screen is large enough for that not to happen by default) */
    max-height: 100%; /* The actual fix, try with and without */
  }
}

Confirmed

  • Frontend changes: tested on a local Flarum installation.

Copy link
Member

@dsevillamartin dsevillamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look like this fixes the issue 👍

@askvortsov1
Copy link
Member

@SychO9 I'm guessing #2628 (comment) would be a separate PR (different bug), so this is probably good to merge?

@SychO9
Copy link
Member Author

SychO9 commented Feb 26, 2021

Yes, separate bug, we can fix that in a separate pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer is partially hidden on small mobile screens when keyboard is open
3 participants